Fix Go to Super Implementation hover link not clickable (#4438)#4440
Merged
datho7561 merged 1 commit intoJun 29, 2026
Merged
Conversation
wenytang-ms
force-pushed
the
fix/hover-super-impl-link-4438
branch
from
775f4e2 to
a4cfa9f
Compare
…oper#4438) The command-link sanitization added in fixJdtSchemeHoverLinks stripped all [label](command:...) links, including the trusted ones the extension contributes (e.g. Go to Super Implementation). Skip sanitizing trusted contributed content; only untrusted server Javadoc is sanitized. Add unit tests covering the hover link sanitization.
wenytang-ms
force-pushed
the
fix/hover-super-impl-link-4438
branch
from
a4cfa9f to
ea2a051
Compare
Contributor
Author
|
@datho7561 @jjohnstn please help review this PR, thanks! |
datho7561
approved these changes
Jun 29, 2026
datho7561
left a comment
datho7561
left a comment
Contributor
There was a problem hiding this comment.
Looks good from my testing. Thanks, @wenytang-ms !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command-link sanitization added in fixJdtSchemeHoverLinks stripped all label links, including the trusted ones the extension contributes (e.g. Go to Super Implementation). Skip sanitizing trusted contributed content; only untrusted server Javadoc is sanitized.
only affected to "Java: Go to Super Implementation" hover.
before
after
relative issue #4438
relative PR #4429