fix: resolve e2e test failures for community plugin build #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The e2e tests were failing due to three issues: - isolated-vm native module build failures during yarn install - Running yarn install from plugin directory instead of workspace root - Missing TypeScript declaration files required for plugin builds This fix: - Uses YARN_ENABLE_SCRIPTS=false to skip native module builds - Installs dependencies from workspace root (workspaces/tech-radar) - Runs yarn tsc at workspace level before building individual plugins - Improves error logging to show detailed failure information Assisted-by: Claude Code Signed-off-by: Tomas Kral <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
YARN_ENABLE_SCRIPTS=falseto skip native module builds during yarn installyarn installandyarn tscfrom workspace root (workspaces/tech-radar)yarn buildin specific plugin directories after TypeScript declarations are generatedWhy skip native module builds?
The workspace includes
isolated-vm, a C++ native module that can fail to compile in CI environments. The plugins being tested don't require it at build time, so we skip native compilation while still installing all JavaScript dependencies.Test plan
yarn test:e2e- all 4 tests pass