Migrate missed PF5 styles to PF6 (#10175)#252
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughSummary by CodeRabbit
WalkthroughMigrates icon color CSS variable references from PatternFly v5 to PatternFly 6 tokens in shared icon constants, graph edge styles, status snapshots, and ESLint configuration. ChangesPatternFly v6 icon token migration
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
- Coverage 11.92% 11.91% -0.02%
==========================================
Files 154 156 +2
Lines 6272 6321 +49
Branches 2028 2178 +150
==========================================
+ Hits 748 753 +5
+ Misses 5524 5345 -179
- Partials 0 223 +223
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/gitops/Statuses/HealthStatus.test.tsx`:
- Around line 11-33: The HealthStatus test file uses JSX in the snapshots and
render calls but is missing the React import required by the current
react/react-in-jsx-scope lint rule. Add the React import at the top of
HealthStatus.test.tsx so the JSX in the HealthStatus test cases compiles and
lints correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 0b335a72-6586-4d90-a02a-d744db6179ae
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (5)
src/gitops/Statuses/HealthStatus.test.tsxsrc/gitops/Statuses/OperationState.test.tsxsrc/gitops/Statuses/SyncStatus.test.tsxsrc/gitops/components/application/graph/ApplicationGraphView.scsssrc/gitops/utils/components/Icons/Icons.tsx
Signed-off-by: Keith Chong <kykchong@redhat.com>
7a0dd27 to
06951b0
Compare
Signed-off-by: Keith Chong <kykchong@redhat.com>
See GITOPS-10175