Skip to content

Migrate missed PF5 styles to PF6 (#10175)#252

Open
keithchong wants to merge 2 commits into
redhat-developer:mainfrom
keithchong:10175-PF6-Styles
Open

Migrate missed PF5 styles to PF6 (#10175)#252
keithchong wants to merge 2 commits into
redhat-developer:mainfrom
keithchong:10175-PF6-Styles

Conversation

@keithchong

Copy link
Copy Markdown
Collaborator

See GITOPS-10175

@openshift-ci
openshift-ci Bot requested a review from wtam2018 June 29, 2026 18:37
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 25431caf-0764-457b-b73a-37bc8a61ed76

📥 Commits

Reviewing files that changed from the base of the PR and between 7a0dd27 and 0b366aa.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (6)
  • .eslintrc.json
  • src/gitops/Statuses/HealthStatus.test.tsx
  • src/gitops/Statuses/OperationState.test.tsx
  • src/gitops/Statuses/SyncStatus.test.tsx
  • src/gitops/components/application/graph/ApplicationGraphView.scss
  • src/gitops/utils/components/Icons/Icons.tsx
🚧 Files skipped from review as they are similar to previous changes (5)
  • src/gitops/components/application/graph/ApplicationGraphView.scss
  • src/gitops/utils/components/Icons/Icons.tsx
  • src/gitops/Statuses/HealthStatus.test.tsx
  • src/gitops/Statuses/SyncStatus.test.tsx
  • src/gitops/Statuses/OperationState.test.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Style

    • Updated status and operation icons to use the latest PatternFly theme colors.
    • Improved consistency for success, warning, error, informational, disabled, and progressing states.
    • Updated application graph edges to reflect the refreshed status color styling.
  • Bug Fixes

    • Corrected icon and status styling across health, sync, and operation-state displays, including popovers and quiet mode.

Walkthrough

Migrates icon color CSS variable references from PatternFly v5 to PatternFly 6 tokens in shared icon constants, graph edge styles, status snapshots, and ESLint configuration.

Changes

PatternFly v6 icon token migration

Layer / File(s) Summary
Icon colors and graph edges
src/gitops/utils/components/Icons/Icons.tsx, src/gitops/components/application/graph/ApplicationGraphView.scss
Exported icon colors and healthy or warning graph edge styles now use PatternFly 6 icon tokens.
Status rendering validation
src/gitops/Statuses/*.test.tsx, .eslintrc.json
Inline snapshots reflect updated SVG icon markup and token names; the React JSX scope lint rule is disabled.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: wtam2018, aali309

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: migrating remaining PatternFly 5 styles to PatternFly 6.
Description check ✅ Passed The description references the linked GITOPS-10175 work item, which is related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 11.91%. Comparing base (01e9db1) to head (0b366aa).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   11.92%   11.91%   -0.02%     
==========================================
  Files         154      156       +2     
  Lines        6272     6321      +49     
  Branches     2028     2178     +150     
==========================================
+ Hits          748      753       +5     
+ Misses       5524     5345     -179     
- Partials        0      223     +223     
Flag Coverage Δ
unit-tests 11.91% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/gitops/Statuses/HealthStatus.test.tsx`:
- Around line 11-33: The HealthStatus test file uses JSX in the snapshots and
render calls but is missing the React import required by the current
react/react-in-jsx-scope lint rule. Add the React import at the top of
HealthStatus.test.tsx so the JSX in the HealthStatus test cases compiles and
lints correctly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 0b335a72-6586-4d90-a02a-d744db6179ae

📥 Commits

Reviewing files that changed from the base of the PR and between 01e9db1 and 7a0dd27.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (5)
  • src/gitops/Statuses/HealthStatus.test.tsx
  • src/gitops/Statuses/OperationState.test.tsx
  • src/gitops/Statuses/SyncStatus.test.tsx
  • src/gitops/components/application/graph/ApplicationGraphView.scss
  • src/gitops/utils/components/Icons/Icons.tsx

Comment thread src/gitops/Statuses/HealthStatus.test.tsx
Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong
keithchong requested a review from aali309 June 29, 2026 19:39
Signed-off-by: Keith Chong <kykchong@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants