feat: add support for ignored network destination type#44
Open
albertoflorez wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the capability to define
ignoredas a validnetwork_destination_typewithin the network mapping templates. This enhancement applies to bothvsphereandovirtproviders.Motivation and Context
When executing large-scale migrations via the Migration Toolkit for Virtualization (MTV) and Migration Factory, there are scenarios where specific source networks do not require a destination target (e.g., deprecated, isolated, or non-routable networks).
Previously, the template forced a fallback to
podormultustypes if the network list wasn't empty, which caused validation or runtime errors during the migration planning phase. Allowing an explicitignoredtype ensures that these networks are properly accounted for in the migration manifests without generating unnecessary target bindings, providing greater flexibility for automated enterprise migration pipelines.Changes Made
vsphere&ovirt): Added a conditional block to evaluate ifnetwork_destination_typeis explicitly set to"ignored".type: ignoredunder the destination metadata block while keeping thesourcedefinition intact.podandmultusnetwork attachment definitions.How This Was Tested
Verified that when
network_destination_type: "ignored"is passed in the overrides, the generated YAML successfully maps the destination as expected: