[PHPUnit 9] Rename assertRegExp/assertNotRegExp to assertMatchesRegularExpression/assertDoesNotMatchRegularExpression on phpunit 90 set

[samsonasik]

ok, on phpunit v8, assertMatchesRegularExpression and assertDoesNotMatchRegularExpression doesn't exists yet, so needs to apply on phpunit 9 set.

Fixes rectorphp/rector#9714

[samsonasik]

Fixed 🎉 /cc @mvhirsch this should work with use phpunit 9 set so the assertRegExp will be renamed on version up to phpunit 9.

[samsonasik]

@TomasVotruba ready 👍

[TomasVotruba]

👍

[mvhirsch]

Fixed 🎉 /cc @mvhirsch this should work with use phpunit 9 set so the assertRegExp will be renamed on version up to phpunit 9.

@samsonasik I'm using PHPUnit v10 that's why it failed in first place (rectorphp/rector#9714) 😊

Thank you!

[mvhirsch]

@samsonasik but I wonder how this is going to fix AssertRegExpRector when running standalone as showcased in my reproducer rectorphp/rector#9714?

I'm not using LevelSet updates, I'm just using this in my rector.dist.php:

->withPreparedSets(deadCode: true, codeQuality: true, typeDeclarations: true, privatization: true, earlyReturn: true, phpunitCodeQuality: true, doctrineCodeQuality: true, symfonyCodeQuality: true)

rector-phpunit/rules/CodeQuality/Rector/MethodCall/AssertRegExpRector.php

Line 166 in 034f8a1

$node->name = new Identifier('assertRegExp');

[samsonasik]

You should can use ->withComposerBased(phpunit: true) or use ->withSets([\Rector\PHPUnit\Set\PHPUnitSetList::PHPUNIT_90])

The target method only exists in phpunit 9+ so use the composer based or use the setlist to update the name.

[mvhirsch]

The target method only exists in phpunit 9+

The target method is assertMatchesRegularExpression, but AssertRegExpRector hard-codes assertRegExp which was removed in v10.

So if I understand you correctly, by using ->withPreparedSets(phpunitCodeQuality: true) I'm implicitely forced to use ->withComposerBased(phpunit: true) (or ->withSets(/* .. */)) in order to tell Rector to use a non-removed method name of PHPUnit since years? I remember a blog post of @TomasVotruba using sets all the time is just a waste of time: running Set upgrades just once, while running quality of life fixes all the time. Maybe that knowledge is outdated? 🤔

I'm not familiar with internals of Rector. Is it common to use the old/deprecated method names in Rectors and rector them with level-sets afterwards on second iteration?

[samsonasik]

I think the AssertRegExpRector can be moved to phpunit 9 rule set, and refactor to change regex function assert to rename to assertMatchesRegularExpression, @mvhirsch could you create PR for it? Thank you.

[mvhirsch]

@mvhirsch could you create PR for it?

No, sorry.

[samsonasik]

Ok, I created PR for it :)

• [PHPunit 9] Move AssertRegExpRector to phpunit 90 set with refactor to use assertMatchesRegularExpression/assertDoesNotMatchRegularExpression #667