Audit fixes: account tests, dependencies and security hardening - #54
Open
tyl-droid wants to merge 3 commits into
Open
Audit fixes: account tests, dependencies and security hardening#54tyl-droid wants to merge 3 commits into
tyl-droid wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit fixes: stale account tests, dependency advisories, upload limit and strict JWT subjects
Hi — I reviewed the current
mainbranch atbc12bb07d4055bf5d85943b67f7379d8ab440c22as part of a preservation-readiness audit and reproduced a few concrete issues.I prepared and validated three small commits locally:
hono:4.12.27→4.13.5wrangler:4.105.0→4.128.0@scalar/api-reference:1.63.0→1.67.0pnpm-lock.yaml.pnpm audit --prod --audit-level=moderatechanged from 12 advisories (3 high, 8 moderate, 1 low) to no known vulnerabilities.RECFLARE_MAX_UPLOAD_BYTESwith a safe 64 MiB default.subparsing reject partial/non-canonical values such as42junk, decimals, signed/zero-padded values and unsafe integers, instead of acceptingparseInt's prefix.Validation:
One limitation remains: multipart parsing occurs before the per-file size check, so this prevents R2 storage abuse but does not fully eliminate request-body memory pressure. A follow-up should enforce an edge/request-body ceiling or introduce streaming multipart handling.
I can provide the three generated Git patches/commits for application. I have not deployed anything or changed upstream code.