docs(cndocs): sync ThemedImage, navigation code blocks, and fix intro-react Tabs - #1033
Merged
Conversation
…-react Tabs structure - _getting-started-macos-ios.md: ThemedImage for Xcode CLI tools screenshot + dark variant - _integration-with-existing-apps-ios.md: ThemedImage for configure release scheme + dark variant - publishing-to-app-store.md: ThemedImage for configure release scheme + dark variant - navigation.md: remove React import, add code block titles, export default, split ProfileScreen - intro-react.md: fix orphaned Tabs/TabItem in state section (add proper wrapping Tabs)
❌ Deploy Preview for reactnativecn failed. Why did it fail? →
|
📝 WalkthroughWalkthroughDocumentation updates across five files: three iOS docs replace static screenshots with ChangesDocumentation Improvements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
cndocs/_integration-with-existing-apps-ios.md (2)
642-645:⚠️ Potential issue | 🟠 Major | ⚡ Quick winFix the Swift
initialPropertiescall syntax.The
view(withModuleName:initialProperties:)call is missing the comma between the module name and the new argument, so this snippet will not compile as written.🛠️ Suggested fix
- view = reactNativeFactory!.rootViewFactory.view(withModuleName: "HelloWorld" initialProperties: [ + view = reactNativeFactory!.rootViewFactory.view(withModuleName: "HelloWorld", initialProperties: [🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cndocs/_integration-with-existing-apps-ios.md` around lines 642 - 645, The Swift method call to view(withModuleName:initialProperties:) is missing a comma between the two named parameters. Add a comma immediately after the "HelloWorld" string and before the initialProperties: parameter label to fix the syntax error. The method signature requires both withModuleName: and initialProperties: arguments to be properly separated by a comma.
549-585:⚠️ Potential issue | 🟡 MinorType the
propsparameter in the code example.The example passes
props.userIDandprops.tokento the component, but the parameter is untyped. Users copying this code snippet into a strict TypeScript project will encounter implicit-anyerrors. Add an explicit type to make the example properly typed.♻️ Suggested fix
+type AppProps = { + userID: string; + token: string; +}; + -function App(props): React.JSX.Element { +function App(props: AppProps): React.JSX.Element {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cndocs/_integration-with-existing-apps-ios.md` around lines 549 - 585, The App function component accepts a props parameter that is untyped, which causes implicit-any errors in strict TypeScript projects. Add an explicit type annotation to the props parameter of the App function to specify the shape of the props object containing userID and token. You can either define an interface for the props object or use an inline type annotation directly on the parameter.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@cndocs/_integration-with-existing-apps-ios.md`:
- Around line 642-645: The Swift method call to
view(withModuleName:initialProperties:) is missing a comma between the two named
parameters. Add a comma immediately after the "HelloWorld" string and before the
initialProperties: parameter label to fix the syntax error. The method signature
requires both withModuleName: and initialProperties: arguments to be properly
separated by a comma.
- Around line 549-585: The App function component accepts a props parameter that
is untyped, which causes implicit-any errors in strict TypeScript projects. Add
an explicit type annotation to the props parameter of the App function to
specify the shape of the props object containing userID and token. You can
either define an interface for the props object or use an inline type annotation
directly on the parameter.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: be70f24e-cb29-4b77-8309-380af99a45b7
⛔ Files ignored due to path filters (2)
cnwebsite/static/docs/assets/ConfigureReleaseSchemeDark.pngis excluded by!**/*.pngcnwebsite/static/docs/assets/GettingStartedXcodeCommandLineToolsDark.pngis excluded by!**/*.png
📒 Files selected for processing (5)
cndocs/_getting-started-macos-ios.mdcndocs/_integration-with-existing-apps-ios.mdcndocs/intro-react.mdcndocs/navigation.mdcndocs/publishing-to-app-store.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
翻译同步 — 2026-06-14
本次从上游同步了以下改动并修复了预存的构建问题：
翻译文件同步
_getting-started-macos-ios.md_integration-with-existing-apps-ios.mdJSX.Element类型更新publishing-to-app-store.mdnavigation.mdexport default、拆分 ProfileScreen 独立代码块intro-react.md</TabItem>/<TabItem>标签（添加缺失的<Tabs>包裹）暗色主题静态资源
cnwebsite/static/docs/assets/ConfigureReleaseSchemeDark.png（新增）cnwebsite/static/docs/assets/GettingStartedXcodeCommandLineToolsDark.png（新增）cnwebsite 配置/依赖
本次上游合并未涉及 cnwebsite 配置或依赖变更（Docusaurus 3.10.1、React 19.2.7 等已是最新）。
构建验证
yarn --cwd cnwebsite build✅ 通过（69s）。已有的 HTML minifier 警告（linking、permissionsandroid、pushnotificationios）为预存问题，与本次改动无关。备注
Summary by CodeRabbit