Skip to content

fix(ios): prevent wrapped text clipping#57535

Open
CreatlV wants to merge 1 commit into
react:mainfrom
CreatlV:codex/fix-ios-wrapped-text-clipping
Open

fix(ios): prevent wrapped text clipping#57535
CreatlV wants to merge 1 commit into
react:mainfrom
CreatlV:codex/fix-ios-wrapped-text-clipping

Conversation

@CreatlV

@CreatlV CreatlV commented Jul 13, 2026

Copy link
Copy Markdown

Summary:

Fixes #53450.

React Native can measure wrapped iOS text to a height that becomes one physical pixel too short after layout rounding. The final visual line is then clipped even though TextKit produced it.

#54260 avoided the clipping by adding an epsilon to every measured width and height, but it changed unrelated measurements and was reverted in #54510 after breaking internal tests. This change narrows the adjustment to the existing textDidWrap signal: wrapped text receives one extra physical pixel of height, while width and all non-wrapped measurements remain unchanged.

This follows the narrower approach proposed by @douglowder in #53450 (comment).

Changelog:

[IOS] [FIXED] - Prevent the final line of wrapped text from being clipped

Test Plan:

  • Reproduced the issue with the canonical fixture from https://snack.expo.dev/@pekka.soutua/text-cut-off-on-ios on an iPhone 16 Pro simulator running iOS 18.5. Before the change, the target paragraph stopped at “This sente”.
  • Applied this wrapped-height-only adjustment and confirmed the complete final line, “This sentence is cut off.”, renders and the following list item moves down by one line.
  • Built RNTester from current main, including the modified source file, for the same iPhone 16 Pro / iOS 18.5 simulator destination.
  • Ran the repository clang formatter on RCTTextLayoutManager.mm.
  • No automated tests were added or run.

@meta-cla

meta-cla Bot commented Jul 13, 2026

Copy link
Copy Markdown

Hi @CreatlV!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text not fully rendered on iOS

1 participant