Skip to content

Add subtitle field to feed and item fields #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rbren wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add subtitle field to feed and item fields #299

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feb5c83
Add subtitle field to feed and item fields
openhands-agent Jan 22, 2026
3d573c0
Remove subtitle field from item fields
openhands-agent Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/fields.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ fields.feed = [
['dc:type', 'type'],
'title',
'description',
'subtitle',
'author',
'pubDate',
'webMaster',
Expand All @@ -35,6 +36,7 @@ fields.item = [
['dc:source', 'source'],
['dc:title', 'title'],
'title',
'subtitle',
Copy link
Copy Markdown
Owner Author

@rbren rbren Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this one @OpenHands

Copy link
Copy Markdown

@openhands-ai openhands-ai Bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on it! rbren can track my progress at all-hands.dev

Copy link
Copy Markdown

@openhands-ai openhands-ai Bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've addressed the PR review comment by removing the subtitle field from the fields.item array in lib/fields.js (line 39).

Summary of changes:

  • ✅ Removed 'subtitle' from fields.item array as requested by @rbren
  • ✅ Kept 'subtitle' in fields.feed array (this was not requested to be removed)
  • ✅ Changes committed and pushed to the add-subtitle-field-to-parser branch

Final PR diff (compared to master):
The PR now only adds subtitle to the feed-level fields, not item-level fields:

fields.feed = [
   ...
   'title',
   'description',
+  'subtitle',
   'author',
   ...

The changes have been pushed to update PR #299.

View full conversation

'link',
'pubDate',
'author',
Expand Down