media: i2c: imx296: Add strobe outputs, controlled by module parameters - #7606
Merged
njhollinghurst merged 1 commit intoSep 14, 2026
Merged
Conversation
Contributor
Author
njhollinghurst
force-pushed
the
imx296-strobes
branch
from
September 4, 2026 15:34
64f6819 to
47c5413
Compare
Contributor
Author
|
version 2: add the missing "fixed at 1" configuration bit; remove workaround. |
6by9
approved these changes
Sep 7, 2026
6by9
left a comment
6by9
left a comment
Contributor
There was a problem hiding this comment.
I would have been tempted to move all the sync stuff out into a function, thereby only adding one line to the upstream imx296_stream_on function. Not critical though, so approved.
(Hmm, I see we're gaining a number of downstream features to this driver - time to clean them up and send them upstream).
njhollinghurst
marked this pull request as ready for review
September 14, 2026 10:53
Enable strobe outputs on IMX296's TOUT[12] pins. During (untriggered) streaming, this pair of pins generate +ve pulses for alternate frames. Pulse width and phase in scanlines (relative to XVS) are configurable using new parameters tout_width, tout_delay. When tout_width == 0, strobes will be disabled (this is the default). Signed-off-by: Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>
njhollinghurst
force-pushed
the
imx296-strobes
branch
from
September 14, 2026 12:12
47c5413 to
e54357a
Compare
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Sep 15, 2026
kernel: drm/mipi-dbi: display a cropped region of an oversized framebuffer See: raspberrypi/linux#7589 kernel: media: i2c: imx296: Add strobe outputs, controlled by module parameters See: raspberrypi/linux#7606 kernel: Correctly unbind CFE See: raspberrypi/linux#7624 kernel: media/hevc_d: Do not reject slice header with bad ref_idx entries See: raspberrypi/linux#7620
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Sep 15, 2026
kernel: drm/mipi-dbi: display a cropped region of an oversized framebuffer See: raspberrypi/linux#7589 kernel: media: i2c: imx296: Add strobe outputs, controlled by module parameters See: raspberrypi/linux#7606 kernel: Correctly unbind CFE See: raspberrypi/linux#7624 kernel: media/hevc_d: Do not reject slice header with bad ref_idx entries See: raspberrypi/linux#7620
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable strobe outputs on IMX296's TOUT[12] pins. During (untriggered) streaming, this pair of pins generate +ve pulses for alternate frames. Pulse width and phase in scanlines (relative to XVS) are configurable using new parameters tout_width, tout_delay. When tout_width == 0, strobes will be disabled (this is the default).