Add support for pps-rp1 dtoverlay. #7209
Conversation
Add support for pps-rp1 dtoverlay. Enables advanced pinctrl features found on RP1 based RPis.
Reformatted whitespace
Even more pedantic whitespace formatting
|
That's an innovative use of the lookup tables. I'll have to see if there is some other, less hacky way to get the RP1 pinctrl driver to use particular GPIOs - perhaps accepting the old brcm,pins format, or the GPIO numbers as strings without the "gpio" prefix - without breaking all the existing uses. The big problem with this submission is that it does nothing: it has no entry in the Makefile, so it won't get compiled, and it has the wrong name - |
Thanks heaps. I wasn't sure with new overlay submissions what process was preferred (ie a dev manually updated the Makefile once the dto was accepted etc). With my own kernel builds, I have amended the filename and added the dtbo to the Makefile, and it compiles up just fine. I have updated my PR but have not forced a push per se. Re: the RP1 pinctrl interface, it was exceedingly annoying and the only (inelegant) solution was to use a LUT. There is no way to coalesce or concatenate values in the DTC. I toyed with the idea of modifying byte-wise but came up against ascii offset vs actual number. I would imagine the LUT, were the pinctrl interface updated, would need to be included there instead. A quick glance at the source would suggest that the whole LUT is necessary because the pins created by label instead |
|
Any ideas on what to do for this 'bad token' error that the dtoverlaycheck process is complaining about? I cannot have more than 100cols in the line without it complaining about length, but then errors out when I have a linebreak and tabs within the quote block? |
|
The line length checks are in checkpatch.pl, a standard kernel dev tool. We don't care about them so much, especially for Device Tree files. What you've done is split a string, which breaks the compilation and confuses the parser. It's better to live with the line length warnings. |
Signed-off-by: Josh Blake <[email protected]>
Signed-off-by: Josh Blake <[email protected]>
|
In other news, I found a small tidbit on the v0.4 DT spec that should allow for string concatenation in the device tree although I think there may be a bug in how it's implemented. I have opened an issue here for clarity on how the spec was defined. I have tried every possible permutation here in label referencing but the DT Overlay crashes out. |
|
I should also add that I wholeheartedly disagree with the dtoverlaycheck script re: 'vestigal' pin use. The overlay clearly defines the bcm2712 and should not (unless the hardware developers intend to redefine pin assignment) do anything untoward. Choosing a param name that is verbose to simply circumvent this check detracts from the descriptive nature of the param as it is, and leads to a counterintuitive experience. |
Relax - I suspect the checker has just been confused by the TABs, and therefore failed to notice the |
Why does the README want spaces and everything else want tabs‽ Signed-off-by: Josh Blake <[email protected]>
|
I'm happy for you to keep pushing updates here, but you may prefer to run |
2 participants
Add support for pps-rp1 dtoverlay. Enables advanced pinctrl features found on RP1 based RPis including Schmitt trigger. Allows multiple PPS devices. Enables the Echo function found on the PPS GPIO kernel module. See https://github.com/josh-blake/pps-rp1 for documentation on the dtoverlay.