Stop workers when job finalization fails - #768
Open
rafael-pissardo wants to merge 2 commits into
Open
Conversation
rafael-pissardo
force-pushed
the
fix/748-claimed-execution-stuck-on-finished-failure
branch
2 times, most recently
from
July 24, 2026 20:03
db4a139 to
d903a36
Compare
Prevent claimed executions from remaining stuck after transient database errors by terminating the owning worker so shutdown releases the claim.
rosa
force-pushed
the
fix/748-claimed-execution-stuck-on-finished-failure
branch
3 times, most recently
from
August 22, 2026 18:57
1e36cfd to
407aff7
Compare
Wrap only the two finalization calls in the guard that escalates still-claimed failures to FinalizationError, and inline the result handling back into perform. The job's own error re-raise no longer passes through the rescue, which spared it a redundant still-claimed check on every ordinarily failing job, and the clause guarding against re-wrapping an already-wrapped error becomes unnecessary. The guard is called finalizing, leaving finalize to the existing single-finalization machinery. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
rosa
force-pushed
the
fix/748-claimed-execution-stuck-on-finished-failure
branch
from
August 22, 2026 19:09
407aff7 to
594cfdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #748.
Test plan
TARGET_DB=sqlite bundle exec ruby -Itest test/unit/worker_test.rbTARGET_DB=sqlite bundle exec ruby -Itest test/models/solid_queue/claimed_execution_test.rbTARGET_DB=sqlite bundle exec ruby -Itest test/integration/jobs_lifecycle_test.rb