Skip to content

Support derived Animate classes in order to use the same axes. - #50

Merged
petercorke merged 1 commit into
rai-opensource:masterfrom
tahsinkose:master
Sep 15, 2026
Merged

petercorke merged 1 commit into
rai-opensource:masterfrom
tahsinkose:master

Conversation

@tahsinkose

Copy link
Copy Markdown
Contributor

Hello there,

I've been using the MATLAB version of these nice toolboxes and just recently finally had a use-case to migrate to Python. I needed to visualize multiple frames in a single animation view. In order to do that, I have to derive from base.animate.Animate and adjust some of the internal data structures. In order to use the same ax as base.animate.Animate does, however, I had to clone this repo and make this change so that all derived classes receive the exact same treatment with the base class.
multiple_frames

@tahsinkose

Copy link
Copy Markdown
Contributor Author

@jhavl this is a rather simple yet capable improvement that provides trivial extensibility of Animate classes. Could you please give it a quick look and merge? 🙏🏼

Cc. @petercorke

@petercorke

Copy link
Copy Markdown
Collaborator

Looks great! I'll have a look at the change on the weekend. There's more I'd like to do with animations but this seems like a win. Thx for your interest

@tahsinkose

Copy link
Copy Markdown
Contributor Author

@petercorke friendly ping 🙂

@tahsinkose

Copy link
Copy Markdown
Contributor Author

Another friendly ping for @jhavl and @myeatman-bdai. This is rather a simple improvement, thus should not take too much of your time. PTAL 🙏🏼

@tahsinkose

Copy link
Copy Markdown
Contributor Author

@baxelrod-bdai could you check please? It is a pretty small PR

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
spatialmath/base/graphics.py 80.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@petercorke petercorke left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really useful small clean fix, embarrassingly long time in approving it.

@petercorke

Copy link
Copy Markdown
Collaborator

@jbarry-bdai rebased and tested, it passes.

@petercorke
petercorke requested a review from taughz as a code owner September 15, 2026 10:36
@petercorke
petercorke merged commit 09b0c43 into rai-opensource:master Sep 15, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants