Fix file-history showing archived revisions as Pending#13
Merged
samth merged 1 commit intoracket:masterfrom Apr 7, 2026
Merged
Fix file-history showing archived revisions as Pending#13samth merged 1 commit intoracket:masterfrom
samth merged 1 commit intoracket:masterfrom
Conversation
show-file-history used file-exists? to check the analyze and analyzed marker files, which fails for archived revisions where those files have been moved into the archive db. Use read-cache* instead so it falls through to the archive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`show-file-history` used `file-exists?` to check the analyze and `analyzed` marker files, which fails for archived revisions where those files have been moved into the archive db. The result was that all archived revisions on a file's history page displayed as "Pending" with no exit code or duration, e.g. on https://drdr.racket-lang.org/file-history/cs/pkgs/compiler-test/tests/compiler/ctool.rkt where 20 of 45 entries were wrongly marked Pending.
The fix uses `read-cache*` instead, which falls through to the archive db when the file isn't on disk. This matches what `next-rev` already does at render.rkt:83.
Test plan