Conversation
samth
force-pushed
the
fix-test-ordering
branch
4 times, most recently
from
fa8b8f4 to
d0875ab
Compare
The timing of when various tests run was significant for both how loaded the drdr machine is and how long the overall test run took. This sorts the paths to restore the previous order. There are surely smarter ideas here but I think this will work.
samth
force-pushed
the
fix-test-ordering
branch
from
d0875ab to
5f2ebbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
links.rktd-based path discovery passed 282 individual link paths instead of the original 3 parent directories, changing the test traversal orderracket-test(the longest-running test) to near the end of the queue, creating a ~60 minute idle tail and causing 3 test timeouts from scheduling changescollects,pkgs/,share/pkgs/), sotest-directoryrecurses into each parent identically to beforeTest plan