chore: explicitly set unicode-segmentation version to 1.13#6463
Merged
Conversation
…oml. Cargo.lock already points to 1.13.2, which introduces significant performance improvement
trinity-1686a
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump
unicode-segmentationfrom"1.12"to"1.13"in the workspaceCargo.toml.Cargo.lockalready resolves to1.13.2, so this change only aligns the minimum version specifier -- no actual dependency version change at build time.Why
unicode-segmentation1.13.2 introduces an ASCII fast path forunicode_word_indicesandunicode_words(unicode-rs/unicode-segmentation#147).Quickwit's
UnicodeSegmenterTokenizercallstext.unicode_word_indices()directly, so this improvement benefits tokenization performance on ASCII-heavy text, which is the common case for most deployments.Other notable changes in the 1.13.x series:
#[inline]opportunities (15-40% general perf improvement)How was this PR tested?
Version-only change in
Cargo.toml.Cargo.lockis unchanged, so the resolved dependency is identical to what was already being built.