Fix segfault in JS_NewSymbol with NULL description and align with ES semantics#1447
Merged
bnoordhuis merged 3 commits intoquickjs-ng:masterfrom Apr 11, 2026
Merged
Fix segfault in JS_NewSymbol with NULL description and align with ES semantics#1447bnoordhuis merged 3 commits intoquickjs-ng:masterfrom
bnoordhuis merged 3 commits intoquickjs-ng:masterfrom
Conversation
Contributor
|
Looks fine to me but can you add a couple of regression tests to api-test.c? |
saghul
approved these changes
Apr 11, 2026
Contributor
Author
|
Done. Added regression tests for both cases to api-test.c. |
bnoordhuis
approved these changes
Apr 11, 2026
Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, calling
JS_NewSymbol(ctx, NULL, false)triggers a segmentation fault becauseJS_NewAtomunconditionally callsstrlen()on thedescription.This PR fixes the crash and aligns the C-API with ECMAScript semantics:
is_global = false): PassingNULLnow creates a description-less Symbol (equivalent toSymbol()), correctly utilizing the internal sentinelJS_NewSymbolInternal(ctx, NULL, ...).is_global = true): PassingNULLnow mimicsSymbol.for(). Per the ES specification,Symbol.for()coercesundefinedto the string"undefined". We fallback theNULLpointer to"undefined", avoiding any artificial C-levelTypeErrorexceptions.This makes
JS_NewSymbolcompletely safe to use with optional C strings.