Draft
Conversation
saghul
commented
Apr 10, 2026
| JS_EXTERN int JS_AddPerformance(JSContext *ctx); | ||
| JS_EXTERN int JS_AddIntrinsicDOMException(JSContext *ctx); | ||
| JS_EXTERN int JS_AddIntrinsicBase64(JSContext *ctx); | ||
| JS_EXTERN int JS_AddIntrinsicAToB(JSContext *ctx); |
Contributor
Author
There was a problem hiding this comment.
I should adjust this in the other PR too.
saghul
commented
Apr 10, 2026
| 'q','r','s','t','u','v','w','x','y','z', | ||
| '0','1','2','3','4','5','6','7','8','9', | ||
| '-','_' | ||
| '+','/' |
Contributor
Author
There was a problem hiding this comment.
I should adjust this in the other PR.
saghul
commented
Apr 10, 2026
| written = b64_encode(data, len, dst); | ||
|
|
||
| if (alphabet == B64_ALPHABET_BASE64URL) { | ||
| for (size_t i = 0; i < written; i++) { |
Contributor
Author
There was a problem hiding this comment.
Is it technically correct to use base64url for atob / btoa? If so, we could perhaps simplify?
saghul
commented
Apr 10, 2026
| } | ||
| } | ||
| if (omit_padding) { | ||
| while (written > 0 && dst[written - 1] == '=') |
Contributor
Author
There was a problem hiding this comment.
Should iterate in reverse.
- Introduce global btoa() and atob() functions - Standard base64 alphabet (RFC 4648) - Decoder implements forgiving-base64-decode (WHATWG Infra spec) - Tolerant to whitespace, validates padding per spec - JS_AddIntrinsicAToB() ensures DOMException is registered Co-authored-by: Saúl Ibarra Corretgé <s@saghul.net>
saghul
force-pushed
the
uint8array-base64
branch
from
30d081c to
3038569
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit is #1444