Draft
Conversation
Collaborator
Author
|
(this bloq is a proof of principle I whipped up quickly. It would need to be integrated into the existing addition bloq. It's missing the first- and last-bit carry eliminations and the final cnots) |
Collaborator
|
What's the issue with the existing adder? In my defense this is a holdover from very early cirq_ft so I'm totally on board with improving it |
Collaborator
Author
|
Tanuj said decomposing a 5000 bit |
Collaborator
Author
|
The timing information is inaccurate in my original post. I need to time the whole cell. It's 1.03s (715ms without the binst graph part) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof of principle, re: #957
There's really no problem working with 5,000+-bit bloqs (and their decomposition) if they're written with a bit of care.
It's an incredibly simplifying assumption that we can expect to be able to do one level of decomposition without blowing our runtime/performance budget