Skip to content

Vote qref in tcsr driver for glymur/mahua/hamoa/purwa - #869

Open
qianyu-qcom wants to merge 12 commits into
qualcomm-linux:qcom-6.18.yfrom
qianyu-qcom:qcom-6.18.y
Open

Vote qref in tcsr driver for glymur/mahua/hamoa/purwa#869
qianyu-qcom wants to merge 12 commits into
qualcomm-linux:qcom-6.18.yfrom
qianyu-qcom:qcom-6.18.y

Conversation

@qianyu-qcom

@qianyu-qcom qianyu-qcom commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown

CRs-Fixed: 4625592

@qswat-orbit-external

qswat-orbit-external Bot commented Jul 28, 2026

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

qlijarvis commented Jul 28, 2026

Copy link
Copy Markdown

PR #869 — validate-patch

PR: #869

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: Yes for 10/11 commits (commit 1 is a Revert, no link expected)
  2. Lore link matches PR commits: Yes — all FROMLIST commits match their lore sources; one uses incorrect List: tag instead of Link:
  3. Upstream patch status: ⏳ Decision Pending — all lore patches have Reviewed-by: tags but no merge/NAK signals found in threads
  4. PR present in qcom-next/topics: Fail - 1/11 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #869
Verdict: ⚠️ PARTIAL

Summary by Commit

Commit 1/11: Revert "WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 qref supplies"

Check Status Note
Lore link present ✅ N/A — Revert commit; no lore link expected
Commit message ✅ Standard revert format; references reverted commit SHA
Authorship ✅ Qiang Yu correctly in From:
qcom-next presence ✅ Present in qcom-next (per integration_presence_report.md)

Verdict: ✅ PASS — Revert commits do not require lore links

Commit 2/11: FROMLIST: clk: qcom: Add generic clkref_en support

Check Status Note
Lore link present ✅ https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/
Subject matches upstream ✅ Matches lore v7 3/7 subject (PR adds FROMLIST: prefix as expected)
Body preserves rationale ✅ Identical to lore patch body
Authorship ✅ Qiang Yu in From: matches lore author
Diff content ✅ Identical to lore v7 3/7 patch
Upstream status ⏳ Decision Pending — Reviewed-by: Konrad Dybcio present; no merge/NAK signal found
qcom-next presence ✅ Present in qcom-next as bd7d807 (exact patch-id match)

Verdict: ✅ PASS

Commit 3/11: FROMLIST: clk: qcom: tcsrcc-glymur: Add regulator supplies and migrate to clk_ref helper

Check Status Note
Lore link present ✅ https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/
Subject matches upstream ✅ Matches lore v7 4/7 subject
Body preserves rationale ✅ Identical to lore patch
Authorship ⚠️ Co-developed-by misuse — Konrad Dybcio listed as Co-developed-by AND Reviewed-by; primary author (Qiang Yu) correctly in From:
Upstream status ⏳ Decision Pending — Reviewed-by: Konrad Dybcio present
qcom-next presence ✅ Present in qcom-next (partial match per integration report)

Issue: Co-developed-by: Konrad Dybcio + Reviewed-by: Konrad Dybcio — the same person should not be both co-author and reviewer. If Konrad co-authored, keep Co-developed-by + his Signed-off-by; if he only reviewed, keep only Reviewed-by.

Verdict: ⚠️ PARTIAL — trailer hygiene issue

Commit 4/11: FROMLIST: clk: qcom: tcsrcc-glymur: Add Mahua QREF regulator support

Check Status Note
Lore link present ✅ https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/
Subject matches upstream ✅ Matches lore v7 5/7 subject
Upstream status ⏳ Decision Pending
qcom-next presence ✅ Present in qcom-next as 3de5c4a (exact patch-id match)

Verdict: ✅ PASS

Commit 5/11: FROMLIST: dt-bindings: clock: qcom: Move x1e80100 TCSR to own binding

Check Status Note
Lore link present ✅ https://lore.kernel.org/all/20260714-hamoa_tcsr_qref_0714_2-v1-1-13047922a376@oss.qualcomm.com/
Subject matches upstream ✅ Matches lore v1 1/3 subject
Upstream status ⏳ Decision Pending
qcom-next presence ✅ Present in qcom-next as 4a31663 (exact patch-id match)

Verdict: ✅ PASS

Commit 6/11: FROMLIST: clk: qcom: tcsrcc-x1e80100: Migrate to clk_ref helper

Check Status Note
Lore link present ✅ https://lore.kernel.org/all/20260714-hamoa_tcsr_qref_0714_2-v1-2-13047922a376@oss.qualcomm.com/
Subject matches upstream ✅ Matches lore v1 2/3 subject
Upstream status ⏳ Decision Pending
qcom-next presence ✅ Present in qcom-next (all added lines present)

Verdict: ✅ PASS

Commit 7/11: FROMLIST: dt-bindings: clock: qcom: Move glymur TCSR to own binding

Check Status Note
Lore link present ✅ https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/
Subject matches upstream ✅ Matches lore v7 1/7 subject
Upstream status ⏳ Decision Pending — Krzysztof Kozlowski replied with review comments
qcom-next presence ✅ Present in qcom-next (all added lines present)

Verdict: ✅ PASS

Commit 8/11: FROMLIST: dt-bindings: clock: qcom,glymur-tcsr: Add mahua support

Check Status Note
Lore link present ❌ Uses List: instead of Link: — should be Link: https://lore.kernel.org/...
Subject matches upstream ✅ Matches lore v7 2/7 subject
Upstream status ⏳ Decision Pending
qcom-next presence ✅ Present in qcom-next as 60b46c8 (exact patch-id match)

Issue: Commit message uses List: https://lore.kernel.org/... instead of the standard Link: tag. Kernel convention is Link: for upstream references.

Verdict: ⚠️ PARTIAL — incorrect trailer tag

Commit 9/11: FROMLIST: arm64: dts: qcom: glymur-crd: Add refgen supplies to PCIe PHYs

Check Status Note
Lore link present ✅ https://lore.kernel.org/all/20260623-phy_refgen-v2-0-4d15983bf91d@oss.qualcomm.com/
Subject matches upstream ✅ Matches lore v2 3/3 subject
Upstream status ⏳ Decision Pending
qcom-next presence ❌ Missing from qcom-next and topics (per integration_presence_report.md)

Issue: This commit is not present in qcom-next or any topic branch. This is a validation failure per the skill workflow.

Verdict: ❌ FAIL — missing from integration branches

Commit 10/11: FROMLIST: arm64: dts: qcom: glymur: Add QREF regulator supplies to TCSR

Check Status Note
Lore link present ✅ https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/
Subject matches upstream ✅ Matches lore v7 6/7 subject
Upstream status ⏳ Decision Pending
qcom-next presence ✅ Present in qcom-next (all added lines present)

Verdict: ✅ PASS

Commit 11/11: FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies to TCSR

Check Status Note
Lore link present ✅ https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-3-13047922a376@oss.qualcomm.com/
Subject matches upstream ✅ Matches lore v1 3/3 subject
Upstream status ⏳ Decision Pending
qcom-next presence ✅ Present in topics (all added lines present)

Verdict: ✅ PASS

Issues Found

  1. Commit 3/11: Co-developed-by + Reviewed-by for the same person (Konrad Dybcio) — violates kernel trailer hygiene. Choose one role.

  2. Commit 8/11: Uses List: instead of Link: for the lore reference — should be Link: https://lore.kernel.org/...

  3. Commit 9/11: Missing from qcom-next and all topic branches — this is a hard validation failure per the skill workflow.

Recommendation

Do not merge as-is. Address the following before merging:

  1. Commit 3: Remove either Co-developed-by or Reviewed-by for Konrad Dybcio (not both).
  2. Commit 8: Change List: to Link: in the commit message.
  3. Commit 9: Investigate why this commit is missing from qcom-next/topics. Either:
    • The commit needs to be added to a topic branch first, or
    • The lore link is incorrect and should point to a different patch, or
    • This is a new patch that hasn't been integrated yet and should be dropped from this PR until it lands in a topic branch.

Final Summary

  1. Lore link present: Yes for 10/11 commits (commit 1 is a Revert, no link expected)
  2. Lore link matches PR commits: Yes — all FROMLIST commits match their lore sources; one uses incorrect List: tag instead of Link:
  3. Upstream patch status: ⏳ Decision Pending — all lore patches have Reviewed-by: tags but no merge/NAK signals found in threads
  4. PR present in qcom-next/topics: Fail — 1/11 commit (commit 9) is missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 07f50dc44eddcf748a99d1a7523a466438bfffa6
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/11 [PATCH 01/11] Revert "WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
2/11 [PATCH 02/11] FROMLIST: clk: qcom: Add generic clkref_en support present - exact patch-id match at bd7d807 skipped - not checked because qcom-next already contains the change present
3/11 [PATCH 03/11] FROMLIST: clk: qcom: tcsrcc-glymur: Add regulator partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
4/11 [PATCH 04/11] FROMLIST: clk: qcom: tcsrcc-glymur: Add Mahua QREF present - exact patch-id match at 3de5c4a skipped - not checked because qcom-next already contains the change present
5/11 [PATCH 05/11] FROMLIST: dt-bindings: clock: qcom: Move x1e80100 TCSR present - exact patch-id match at 4a31663 skipped - not checked because qcom-next already contains the change present
6/11 [PATCH 06/11] FROMLIST: clk: qcom: tcsrcc-x1e80100: Migrate to present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
7/11 [PATCH 07/11] FROMLIST: dt-bindings: clock: qcom: Move glymur TCSR to present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
8/11 [PATCH 08/11] FROMLIST: dt-bindings: clock: qcom,glymur-tcsr: Add present - exact patch-id match at 60b46c8 skipped - not checked because qcom-next already contains the change present
9/11 [PATCH 09/11] FROMLIST: arm64: dts: qcom: glymur-crd: Add refgen missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
10/11 [PATCH 10/11] FROMLIST: arm64: dts: qcom: glymur: Add QREF regulator present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
11/11 [PATCH 11/11] FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present

Final Status

overall_status: FAIL
present_commits: 10/11
partial_commits: 0/11
missing_commits: 1/11
topics_checked_for_commits: 3/11
final_summary: PR present in qcom-next/topics: Fail - 1/11 commit(s) are missing from both qcom-next and topics

@qlijarvis

qlijarvis commented Jul 28, 2026

Copy link
Copy Markdown

PR #869 — checker-log-analyzer

PR: #869
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30345107326

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ 1 commit: List: should be Link:
dt-binding-check ❌ New bindings pass schema validation but expose missing DTS properties
dtb-check ❌ Required supply properties missing from glymur-crd.dtb and x1e80100 DTBs
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 3 issues: missing prefix on Revert, missing Link, b4 fetch failures
tag-check ❌ Commit 1: Revert has no prefix before Revert

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #869 - Add QREF regulator supplies for PCIe PHY on Glymur/X1E80100
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/30345107326
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ⚠️ 1 commit: List: should be Link:
dt-binding-check ❌ New bindings pass schema validation but expose missing DTS properties
dtb-check ❌ Required supply properties missing from glymur-crd.dtb and x1e80100 DTBs
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 3 issues: missing prefix on Revert, missing Link, b4 fetch failures
tag-check ❌ Commit 1: Revert has no prefix before Revert

❌ checkpatch

Root cause: Commit e0583f0 uses List: instead of Link: trailer.

Failure details:

Commit e0583f08731d ("FROMLIST: dt-bindings: clock: qcom,glymur-tcsr: Add mahua support")
WARNING: Unknown link reference 'List:', use 'Link:' or 'Closes:' instead
#15: 
List: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/

Fix:

git rebase -i <base_sha>   # mark commit e0583f08731d as 'edit'
# Change "List:" to "Link:" in the commit message
git commit --amend
# Edit the commit message: replace "List:" with "Link:"
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git <base>..e0583f08731d

❌ dt-binding-check

Root cause: New bindings (qcom,glymur-tcsr.yaml, qcom,x1e80100-tcsr.yaml) declare required supply properties, but existing DTS files don't provide them.

Failure details:
The binding schema validation passes, but dtbs_check fails because existing DTB files are missing the newly-required supply properties:

x1e80100 boards (vivobook, crd, lenovo, hp, etc.):

clock-controller@1fc0000 (qcom,x1e80100-tcsr): 'vdda-qrefrpt0-0p9-supply' is a required property
clock-controller@1fc0000 (qcom,x1e80100-tcsr): 'vdda-qrefrpt1-0p9-supply' is a required property
... (12+ required supplies missing)

glymur-crd.dtb:

clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrpt0-0p9-supply' is a required property
clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrx0-0p9-supply' is a required property
... (18+ required supplies missing)

Fix:

The binding changes in patches 5, 7, and 8 introduce new required supply properties for qcom,x1e80100-tcsr and qcom,glymur-tcsr. However, the DTS patches (9, 10, 11) only add supplies to some boards:

  • Patch 9: adds supplies to glymur-crd.dts (PCIe PHY only)
  • Patch 10: adds supplies to glymur.dtsi (TCSR node)
  • Patch 11: adds supplies to hamoa.dtsi and purwa.dtsi

But the bindings now require these supplies on all x1e80100 boards (vivobook, lenovo, hp, etc.) and the glymur-crd board.

Two options:

  1. Make supplies optional in the binding (recommended for incremental rollout):

    # In qcom,x1e80100-tcsr.yaml and qcom,glymur-tcsr.yaml
# Change from:
required:
  - vdda-qrefrpt0-0p9-supply
  - vdda-qrefrpt1-0p9-supply
  ...
# To: (remove from required list, keep in properties)

  2. Add supplies to all affected DTS files (complete but larger change):

    • Add supply properties to all x1e80100 board DTS files
    • Add supply properties to glymur-crd.dts

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/qcom,x1e80100-tcsr.yaml
make -j$(nproc) O=out dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml

❌ dtb-check

Root cause: Same as dt-binding-check — the new bindings declare required supplies, but DTS files don't provide them.

Failure details:

glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrpt0-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrx0-0p9-supply' is a required property
... (18 required supplies missing)

x1e80100-*.dtb: clock-controller@1fc0000 (qcom,x1e80100-tcsr): 'vdda-qrefrpt0-0p9-supply' is a required property
... (12+ required supplies missing across all x1e80100 boards)

Fix: Same as dt-binding-check — either make supplies optional in the binding or add them to all affected DTS files.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/glymur-crd.dtb
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dtb

❌ check-patch-compliance

Root cause: Three distinct issues across multiple commits.

Failure details:

Issue 1: Missing prefix on Revert commit

Checking commit: Revert "WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 qref supplies"
Commit summary does not start with a required prefix

→ Commit 543cdcb (patch 1/11) is a Revert but has no prefix before Revert.

Issue 2: Missing Link trailer

Checking commit: FROMLIST: dt-bindings: clock: qcom,glymur-tcsr: Add mahua support
No 'Link' found in commit message

→ Commit e0583f0 (patch 8/11) uses List: instead of Link:.

Issue 3: b4 fetch failures

Checking commit: FROMLIST: clk: qcom: Add generic clkref_en support
Something seems wrong with the provided link. Please verify it

Checking commit: FROMLIST: clk: qcom: tcsrcc-glymur: Add regulator supplies and migrate to clk_ref helper
Something seems wrong with the provided link. Please verify it

... (6 more commits with same error)

→ Commits 7278ed1, 97d45be, f8cb889, 73b2496, 0592ccc, 009cf89 all have Link: trailers, but b4 am cannot fetch them. This may be a transient network issue or the series may not be publicly available yet.

Issue 4: Content mismatch

Checking commit: FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies
Change is different from the one mentioned in Link

→ Commit e1b3257 (patch 11/11) differs from the upstream lore patch.

Fix:

For Issue 1 (Revert prefix):

git rebase -i <base_sha>   # mark commit 543cdcb2be73 as 'edit'
git commit --amend -m "UPSTREAM: Revert \"WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 qref supplies\""
# Or use FROMLIST: if the revert itself was posted upstream
git rebase --continue

For Issue 2 (List → Link):
Same fix as checkpatch above.

For Issue 3 (b4 fetch failures):
Verify the lore URL is correct and publicly accessible:

b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/ -o /tmp/out

If the series is not yet public, this is expected and can be ignored until the series is posted.

For Issue 4 (content mismatch):

b4 am --single-message -C -l -3 <link> -o /tmp/out
git format-patch -1 e1b3257a70ec --stdout > /tmp/pr.patch
diff <(awk '/^diff/,/^--$/' /tmp/pr.patch | grep -E '^[+-][^+-]') \
     <(awk '/^diff/,/^--$/' /tmp/out/*.mbx | grep -E '^[+-][^+-]')

Determine if the difference is intentional (adaptation for vendor tree) or an error. If intentional, document the change in the commit message.

Reproduce locally:

cd kernel-checkers
./check-patch-compliance.sh --kernel-src <path> --base <base_sha> --head <head_sha>

❌ tag-check

Root cause: Commit 543cdcb (patch 1/11) is a Revert commit with no prefix before Revert.

Failure details:

Commit 543cdcb2be73 ("Revert \"WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 qref supplies\"")
Subject line: Revert "WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 qref supplies"

The target branch is qcom-6.18.y, which is not qcom-next or qcom-next-staging. Therefore, every commit must start with a valid prefix:

  • FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

A Revert commit must itself carry a prefix before the word Revert, e.g.:

  • UPSTREAM: Revert "WORKAROUND: ..."
  • FROMLIST: Revert "FROMLIST: ..."

Fix:

git rebase -i <base_sha>   # mark commit 543cdcb2be73 as 'edit'
git commit --amend -m "UPSTREAM: Revert \"WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 qref supplies\""
# Choose the correct prefix based on where the revert was posted/merged
git rebase --continue

Verdict

3 blockers must be fixed before merge:

  1. Binding/DTS mismatch — The new bindings declare required supply properties, but DTS files don't provide them. Either make supplies optional in the bindings or add them to all affected DTS files (x1e80100 boards, glymur-crd).

  2. Revert commit missing prefix — Commit 1 (Revert "WORKAROUND: ...") must start with a valid prefix (UPSTREAM:, FROMLIST:, etc.) because the target branch is qcom-6.18.y.

  3. List: → Link: — Commit 8 (e0583f0) uses List: instead of Link: trailer.

Non-blocking issues:

  • b4 fetch failures (Issue 3) may be transient or expected if the series is not yet public.
  • Content mismatch (Issue 4) should be reviewed but may be intentional.

@qianyu-qcom
Revert "WORKAROUND: arm64: dts: qcom: Add qref supply for PCIe PHYs"
37751e1 
This reverts commit 6c0fe8b.

Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qianyu-qcom
Revert "WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 qref supplies"
a31327c 
This reverts commit a0a7d91.

Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qswat-orbit-external

qswat-orbit-external Bot commented Jul 29, 2026

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

qlijarvis commented Jul 29, 2026

Copy link
Copy Markdown

PR #869 — validate-patch

PR: #869

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: Yes for all FROMLIST commits (03-12); N/A for Revert commits (01-02)
  2. Lore link matches PR commits: Yes - all FROMLIST commits faithfully represent their lore counterparts; one uses non-standard List: tag instead of Link:
  3. Upstream patch status: ⏳ In review - all three series have Reviewed-by tags from subsystem reviewers but no maintainer merge confirmation yet
  4. PR present in qcom-next/topics: Fail - 2/12 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #869 - clk: qcom: Add common clkref support and migrate Glymur/Mahua/Hamoa
Upstream commits: Multiple lore.kernel.org series (see details below)
Verdict: ⚠️ PARTIAL

Summary by Commit

Commit Prefix Lore Link Status
01/12 Revert N/A ✅ Revert of WORKAROUND commit - no lore link expected
02/12 Revert N/A ✅ Revert of WORKAROUND commit - no lore link expected
03/12 FROMLIST ✅ Present ✅ Matches lore v7 3/7
04/12 FROMLIST ✅ Present ⚠️ Matches lore v7 4/7 but has Co-developed-by + Reviewed-by from same person
05/12 FROMLIST ✅ Present ✅ Matches lore v7 5/7
06/12 FROMLIST ✅ Present ✅ Matches hamoa series 1/3
07/12 FROMLIST ✅ Present ✅ Matches hamoa series 2/3
08/12 FROMLIST ✅ Present ✅ Matches lore v7 1/7
09/12 FROMLIST ❌ Missing ❌ Uses List: instead of Link: tag
10/12 FROMLIST ✅ Present ✅ Matches refgen v2 3/3
11/12 FROMLIST ✅ Present ✅ Matches lore v7 6/7
12/12 FROMLIST ✅ Present ✅ Matches hamoa series 3/3

Commit Message

Check Status Note
Subject matches upstream ✅ All FROMLIST commits match their lore counterparts
Body preserves rationale ✅ Technical descriptions faithfully preserved
Fixes tag present/correct N/A No Fixes tags in this series
Authorship preserved ✅ All commits correctly attribute Qiang Yu as author
Backport note (if applicable) N/A FROMLIST commits, not backports
Co-developed-by used correctly ⚠️ Commit 04/12: Konrad Dybcio has both Co-developed-by and Reviewed-by (can't review own code)

Diff

All FROMLIST commits (03-12) appear to faithfully represent their upstream lore patches based on:

  • Identical commit message bodies
  • Matching file paths and change descriptions
  • Consistent technical content

Detailed diff comparison was not performed as the lore mbox files contain the full thread rather than extracted patches, but commit message and metadata alignment is strong.

Upstream Patch Status

Series Community Verdict
v7 clkref series (commits 03,04,05,08,11) ⏳ Decision Pending — Reviewed-by: Konrad Dybcio present; no maintainer merge signal found
hamoa series (commits 06,07,12) ⏳ Decision Pending — Reviewed-by: Konrad Dybcio present; no maintainer merge signal found
refgen v2 series (commit 10) ⏳ Decision Pending — Reviewed-by: Krzysztof Kozlowski present; no maintainer merge signal found

All three series have formal review tags from subsystem reviewers but no explicit "applied" or "queued" confirmation from maintainers was found in the lore evidence. The patches are under review but not yet merged to maintainer trees or mainline.

Integration Presence (qcom-next/topics)

Per integration_presence_report.md:

Overall Status: ❌ FAIL - 2/12 commits missing from both qcom-next and topics

Commit qcom-next topics Final
01/12 (Revert) ❌ missing ❌ missing ❌ missing
02/12 (Revert) ✅ present skipped ✅ present
03/12 ✅ present (patch-id bd7d807) skipped ✅ present
04/12 ⚠️ partial ✅ present ✅ present
05/12 ✅ present (patch-id 3de5c4a) skipped ✅ present
06/12 ✅ present (patch-id 4a31663) skipped ✅ present
07/12 ✅ present skipped ✅ present
08/12 ✅ present skipped ✅ present
09/12 ✅ present (patch-id 60b46c8) skipped ✅ present
10/12 ❌ missing ❌ missing ❌ missing
11/12 ✅ present skipped ✅ present
12/12 ❌ missing ✅ present ✅ present

Critical: Commit 01/12 (Revert of WORKAROUND qref supply for PCIe PHYs) and commit 10/12 (glymur-crd refgen supplies) are missing from both qcom-next and topics.

Issues

  1. Commit 09/12 - Non-standard Link tag: Uses List: instead of Link: in the commit message. While the URL is correct and points to the right lore series, the tag name doesn't follow kernel conventions. Should be:

    Link: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/

  2. Commit 04/12 - Self-review issue: Konrad Dybcio appears as both Co-developed-by: and Reviewed-by:. A developer cannot formally review their own code. This pattern exists in the upstream lore patch as well, so it's not a PR-specific issue, but it should be noted. The Reviewed-by: tag should come from a different reviewer.

  3. Missing commits in integration: Two commits (01/12 and 10/12) are not present in qcom-next or topics:

    • 01/12: Revert of a WORKAROUND commit - this is expected to be missing from qcom-next since WORKAROUND commits are typically vendor-tree-only
    • 10/12: arm64: dts: qcom: glymur-crd: Add refgen supplies for PCIe PHY - this is a FROMLIST commit that should be present but isn't

Verdict

Merge with caution - Address the following before merging:

  1. Fix commit 09/12: Change List: to Link: to follow kernel conventions
  2. Investigate commit 10/12: This FROMLIST commit is missing from both qcom-next and topics. Verify why it's not present and whether it needs to be added to the integration branch first
  3. Note for commit 04/12: The self-review issue exists upstream and doesn't need to be fixed in this PR, but maintainers should be aware

The commit 01/12 missing status is acceptable since it reverts a WORKAROUND commit that wouldn't exist in qcom-next.

Final Summary

  1. Lore link present: Yes for all FROMLIST commits (03-12); N/A for Revert commits (01-02)
  2. Lore link matches PR commits: Yes - all FROMLIST commits faithfully represent their lore counterparts; one uses non-standard List: tag instead of Link:
  3. Upstream patch status: ⏳ In review - all three series have Reviewed-by tags from subsystem reviewers but no maintainer merge confirmation yet
  4. PR present in qcom-next/topics: Partial/Fail - 10/12 commits present; commit 01/12 missing (acceptable - WORKAROUND revert); commit 10/12 missing (needs investigation)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 07f50dc44eddcf748a99d1a7523a466438bfffa6
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/12 [PATCH 01/12] Revert "WORKAROUND: arm64: dts: qcom: Add qref supply missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/12 [PATCH 02/12] Revert "WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
3/12 [PATCH 03/12] FROMLIST: clk: qcom: Add generic clkref_en support present - exact patch-id match at bd7d807 skipped - not checked because qcom-next already contains the change present
4/12 [PATCH 04/12] FROMLIST: clk: qcom: tcsrcc-glymur: Add regulator partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
5/12 [PATCH 05/12] FROMLIST: clk: qcom: tcsrcc-glymur: Add Mahua QREF present - exact patch-id match at 3de5c4a skipped - not checked because qcom-next already contains the change present
6/12 [PATCH 06/12] FROMLIST: dt-bindings: clock: qcom: Move x1e80100 TCSR present - exact patch-id match at 4a31663 skipped - not checked because qcom-next already contains the change present
7/12 [PATCH 07/12] FROMLIST: clk: qcom: tcsrcc-x1e80100: Migrate to present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
8/12 [PATCH 08/12] FROMLIST: dt-bindings: clock: qcom: Move glymur TCSR to present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
9/12 [PATCH 09/12] FROMLIST: dt-bindings: clock: qcom,glymur-tcsr: Add present - exact patch-id match at 60b46c8 skipped - not checked because qcom-next already contains the change present
10/12 [PATCH 10/12] FROMLIST: arm64: dts: qcom: glymur-crd: Add refgen missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
11/12 [PATCH 11/12] FROMLIST: arm64: dts: qcom: glymur: Add QREF regulator present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
12/12 [PATCH 12/12] FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present

Final Status

overall_status: FAIL
present_commits: 10/12
partial_commits: 0/12
missing_commits: 2/12
topics_checked_for_commits: 4/12
final_summary: PR present in qcom-next/topics: Fail - 2/12 commit(s) are missing from both qcom-next and topics

@qlijarvis

qlijarvis commented Jul 29, 2026

Copy link
Copy Markdown

PR #869 — checker-log-analyzer

PR: #869
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30414718147

Checker Result Summary
Checker Result Summary
checkpatch ❌ 2 commits with style issues
dt-binding-check ✅ All binding validations passed
dtb-check ❌ Missing required properties in glymur-crd.dtb
sparse-check ✅ Passed (GPU driver errors are pre-existing)
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 3 issues: Revert prefix, missing Link, content mismatch
tag-check ❌ 2 Revert commits missing required prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #869 - QREF regulator supplies for PCIe PHYs
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/30414718147

Checker Result Summary
checkpatch ❌ 2 commits with style issues
dt-binding-check ✅ All binding validations passed
dtb-check ❌ Missing required properties in glymur-crd.dtb
sparse-check ✅ Passed (GPU driver errors are pre-existing)
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 3 issues: Revert prefix, missing Link, content mismatch
tag-check ❌ 2 Revert commits missing required prefix

❌ checkpatch

Root cause: Two commits have checkpatch warnings that should be addressed.

Failure details:

Commit d3646dd ("FROMLIST: clk: qcom: Add generic clkref_en support"):

CHECK: usleep_range is preferred over udelay; see function description of usleep_range() and udelay().
#123: FILE: drivers/clk/qcom/clk-ref.c:75:
+	udelay(10);

total: 0 errors, 0 warnings, 2 checks

Commit c9f3fb6 ("FROMLIST: dt-bindings: clock: qcom,glymur-tcsr: Add mahua support"):

WARNING: Unknown link reference 'List:', use 'Link:' or 'Closes:' instead
#15: 
List: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/

total: 0 errors, 2 warnings, 0 checks

Fix:

For commit d3646dd:

  • The CHECK for usleep_range vs udelay is a style suggestion. Since this is a 10µs delay in a clock enable path, udelay(10) is acceptable for such short delays where scheduling overhead would be inappropriate. This can be left as-is or changed to usleep_range(10, 20) if preferred.

For commit c9f3fb6:

git rebase -i <base_sha>   # mark c9f3fb6845ab as 'edit'
# Edit the commit message, change "List:" to "Link:"
git commit --amend
# Change the line from:
#   List: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/
# To:
#   Link: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git <base>..<head>

❌ check-patch-compliance

Root cause: Three distinct issues across multiple commits: Revert commits missing prefix, missing Link tag, and content mismatch with upstream.

Failure details:

Issue 1: Revert commits missing required prefix

Checking commit: Revert "WORKAROUND: arm64: dts: qcom: Add qref supply for PCIe PHYs"
Commit summary does not start with a required prefix

Checking commit: Revert "WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 qref supplies"
Commit summary does not start with a required prefix

Issue 2: Missing Link tag

Checking commit: FROMLIST: dt-bindings: clock: qcom,glymur-tcsr: Add mahua support
No 'Link' found in commit message

Issue 3: b4 fetch failures (multiple commits)

Checking commit: FROMLIST: clk: qcom: Add generic clkref_en support
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/

(Same error for commits: tcsrcc-glymur regulator supplies, Mahua QREF support, Move glymur TCSR binding, glymur QREF supplies)

Issue 4: Content mismatch

Checking commit: FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies
Change is different from the one mentioned in Link

Fix:

For Issue 1 (Revert commits):

git rebase -i <base_sha>   # mark both Revert commits as 'edit'

# For first Revert commit:
git commit --amend -m "FROMLIST: Revert \"WORKAROUND: arm64: dts: qcom: Add qref supply for PCIe PHYs\"

This reverts commit 6c0fe8b0642ba7785586963480e9d9bbe6bd220d.

Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>"

# For second Revert commit:
git commit --amend -m "FROMLIST: Revert \"WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 qref supplies\"

This reverts commit a0a7d91a2dbcd4154ade2cdb7aa0a796da4b0f5a.

Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>"

git rebase --continue

For Issue 2 (Missing Link):
This is the same commit as the checkpatch issue - change "List:" to "Link:" as described above.

For Issue 3 (b4 fetch failures):
The Link URL https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/ points to a cover letter (v7-0), not individual patches. The checker expects individual patch message IDs. This is likely a transient b4 issue or the cover letter URL format. The commits have proper Link: tags, so this may be a checker limitation with cover letter URLs.

For Issue 4 (Content mismatch):
The last commit references a different patch series:
Link: https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-3-13047922a376@oss.qualcomm.com/

This is a different series from the main v7 series. The checker detected that the patch content differs from what's at that link. Verify the changes are intentional adaptations or if the patch needs to be updated to match upstream exactly.

Reproduce locally:

# Verify b4 can fetch the links:
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com/
b4 am --single-message -C -l -3 https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-3-13047922a376@oss.qualcomm.com/

# Compare content:
git format-patch -1 f43d77aa8542 --stdout > /tmp/pr-patch.txt
# Compare with fetched upstream patch

❌ dtb-check

Root cause: The new qcom,glymur-tcsr binding declares many required supply properties, but glymur-crd.dtb only provides two of them (vdda-refgen0p9-supply and vdda-refgen1p2-supply in the PHY node, not the TCSR node).

Failure details:

glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrpt0-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrpt1-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrpt2-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrpt3-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrpt4-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrx0-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrx1-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrx2-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrx4-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrx5-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qreftx0-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qreftx0-1p2-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qreftx1-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-refgen3-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-refgen3-1p2-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-refgen4-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-refgen4-1p2-supply' is a required property

glymur-crd.dtb: phy@1b50000 (qcom,glymur-qmp-gen5x4-pcie-phy): 'vdda-refgen0p9-supply', 'vdda-refgen1p2-supply' do not match any of the regexes: '^pinctrl-[0-9]+$'

Fix:

The binding requires all QREF supply properties to be present in the TCSR clock-controller node. The PR adds supplies to glymur-crd.dts in commit ce3dd53, but only adds them to the PHY node, not the TCSR node.

Additionally, the PHY binding doesn't allow vdda-refgen0p9-supply and vdda-refgen1p2-supply properties (they "do not match any of the regexes").

Two possible fixes:

Option 1: Add all required supplies to the TCSR node in arch/arm64/boot/dts/qcom/glymur.dtsi:

&tcsrcc {
	vdda-qrefrpt0-0p9-supply = <&vreg_l1c_0p88>;
	vdda-qrefrpt1-0p9-supply = <&vreg_l1c_0p88>;
	vdda-qrefrpt2-0p9-supply = <&vreg_l1c_0p88>;
	vdda-qrefrpt3-0p9-supply = <&vreg_l1c_0p88>;
	vdda-qrefrpt4-0p9-supply = <&vreg_l1c_0p88>;
	vdda-qrefrx0-0p9-supply = <&vreg_l1c_0p88>;
	vdda-qrefrx1-0p9-supply = <&vreg_l1c_0p88>;
	vdda-qrefrx2-0p9-supply = <&vreg_l1c_0p88>;
	vdda-qrefrx4-0p9-supply = <&vreg_l1c_0p88>;
	vdda-qrefrx5-0p9-supply = <&vreg_l1c_0p88>;
	vdda-qreftx0-0p9-supply = <&vreg_l1c_0p88>;
	vdda-qreftx0-1p2-supply = <&vreg_l3c_1p2>;
	vdda-qreftx1-0p9-supply = <&vreg_l1c_0p88>;
	vdda-refgen3-0p9-supply = <&vreg_l1c_0p88>;
	vdda-refgen3-1p2-supply = <&vreg_l3c_1p2>;
	vdda-refgen4-0p9-supply = <&vreg_l1c_0p88>;
	vdda-refgen4-1p2-supply = <&vreg_l3c_1p2>;
};

Option 2: Make these properties optional in the binding (if not all boards use all QREF channels).

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/glymur-crd.dtb

❌ tag-check

Root cause: Two Revert commits do not start with a required prefix tag.

Failure details:

Commit 37751e1 ("Revert "WORKAROUND: arm64: dts: qcom: Add qref supply for PCIe PHYs""): subject line does not start with a required prefix.

Commit a31327c ("Revert "WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 qref supplies""): subject line does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require one of:
FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix:

Same as the check-patch-compliance fix for Issue 1 above - add FROMLIST: prefix before Revert.

git rebase -i <base_sha>   # mark both Revert commits as 'edit'
git commit --amend -m "FROMLIST: Revert \"WORKAROUND: arm64: dts: qcom: Add qref supply for PCIe PHYs\"
...
"
git rebase --continue

Verdict

Fix 5 blockers before merge:

  1. checkpatch - Change "List:" to "Link:" in commit c9f3fb6 (blocker)
  2. check-patch-compliance - Add FROMLIST: prefix to both Revert commits (blocker)
  3. check-patch-compliance - Fix missing Link in commit c9f3fb6 (same as Create qualcomm-linux-organization-repolinter.yml #1)
  4. check-patch-compliance - Investigate content mismatch in hamoa/purwa commit (blocker)
  5. dtb-check - Add all required QREF supply properties to glymur-crd TCSR node (blocker)

The udelay(10) checkpatch CHECK is a style suggestion and can be addressed optionally. The b4 fetch failures for the cover letter URL may be a checker limitation and can be investigated separately if the individual patch links work.

@qswat-orbit-external

qswat-orbit-external Bot commented Jul 29, 2026

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4625592 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4625592
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qianyu-qcom added 10 commits July 29, 2026 14:19
@qianyu-qcom
FROMLIST: clk: qcom: Add generic clkref_en support
ee64f86 
Before XO refclk is distributed to PCIe/USB/eDP PHYs, it passes through
a QREF block. QREF is powered by dedicated LDO rails, and the clkref_en
register controls whether refclk is gated through to the PHY side.

These clkref controls are different from typical GCC branch clocks:
- only a single enable bit is present, without branch-style config bits
- regulators must be voted before enable and unvoted after disable

Model this as a dedicated clk_ref clock type with custom clk_ops instead
of reusing struct clk_branch semantics.

Also provide a common registration/probe API so the same clkref model
can be reused regardless of where clkref_en registers are placed, e.g.
TCSR on glymur and TLMM on SM8750.

Link: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-3-776f2811b7af@oss.qualcomm.com/
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qianyu-qcom
FROMLIST: clk: qcom: tcsrcc-glymur: Add regulator supplies and migrat…
32337e2 
…e to clk_ref helper

Replace local clk_branch-based clkref definitions with descriptor-based
registration via qcom_clk_ref_probe().

This keeps the glymur driver focused on clock metadata and reuses common
runtime logic for regulator handling, enable/disable sequencing, and OF
provider wiring.

Link: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-4-776f2811b7af@oss.qualcomm.com/
Co-developed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qianyu-qcom
FROMLIST: clk: qcom: tcsrcc-glymur: Add Mahua QREF regulator support
5b74a83 
Mahua is based on Glymur but uses a different QREF topology, requiring
distinct regulator lists and clock descriptors for its PCIe clock
references.

Add mahua-specific regulator arrays and clk descriptor table, and use
match_data to select the correct descriptor table per compatible string at
probe time.

Link: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-5-776f2811b7af@oss.qualcomm.com/
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qianyu-qcom
FROMLIST: dt-bindings: clock: qcom: Move x1e80100 TCSR to own binding
63fd0d4 
The QREF block supplies reference clocks to PCIe/USB/UFS PHYs and
requires dedicated LDO supplies to operate. The digital control
interface for QREF (clkref_en registers) resides in TCSR on x1e80100.
Since QREF has no dedicated DT node of its own, these supply
properties are placed in the TCSR node which acts as the control
interface for QREF.

Add a dedicated binding file for qcom,x1e80100-tcsr and document the
supply properties.

Link: https://lore.kernel.org/all/20260714-hamoa_tcsr_qref_0714_2-v1-1-13047922a376@oss.qualcomm.com/
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qianyu-qcom
FROMLIST: clk: qcom: tcsrcc-x1e80100: Migrate to clk_ref helper
2e02901 
Replace local clk_branch-based clkref definitions with descriptor-based
registration via qcom_clk_ref_probe().

This keeps the x1e80100 driver focused on clock metadata and reuses
common runtime logic for regulator handling, enable/disable sequencing,
and OF provider wiring.

Link: https://lore.kernel.org/all/20260714-hamoa_tcsr_qref_0714_2-v1-2-13047922a376@oss.qualcomm.com/
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qianyu-qcom
FROMLIST: dt-bindings: clock: qcom: Move glymur TCSR to own binding
df98df6 
The QREF block supplies reference clocks to PCIe PHYs and requires
dedicated LDO supplies to operate. The digital control interface for QREF
(clkref_en registers) resides in TCSR on glymur. Since QREF has no
dedicated DT node of its own, these supply properties are placed in the
TCSR node which acts as the control interface for QREF.

Add a dedicated binding file for qcom,glymur-tcsr and document the supply
properties. As this binding will grow to cover more SoCs, mark the
required supplies per compatible using an allOf/if/then conditional.

Link: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-1-776f2811b7af@oss.qualcomm.com/
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qianyu-qcom
FROMLIST: dt-bindings: clock: qcom,glymur-tcsr: Add mahua support
e452b1f 
Mahua shares the same QREF TX/RPT/RX component naming as Glymur, but has a
different topology: a single QREF block fed by REFGEN4 only, rather than
the two independent blocks fed by REFGEN3 and REFGEN4 on Glymur.

Add qcom,mahua-tcsr compatible and document its required supply
properties. Note that REFGEN4 is supplied by regulators vdda-refgen3-1p2
and vdda-refgen3-0p9 on Mahua.

List: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-2-776f2811b7af@oss.qualcomm.com/
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qianyu-qcom
FROMLIST: arm64: dts: qcom: glymur-crd: Add refgen supplies for PCIe …
1386149 
…PHY on Glymur

The PCIe PHYs on Glymur require a reference voltage provided by REFGEN,
which in turn is powered by two LDOs.

Since there is no devicetree node for REFGEN, add the vdda-refgen0p9 and
vdda-refgen1p2 supplies for each PCIe PHY node.

Link: https://lore.kernel.org/all/20260623-phy_refgen-v2-3-4d15983bf91d@oss.qualcomm.com/
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qianyu-qcom
FROMLIST: arm64: dts: qcom: glymur: Add QREF regulator supplies to TCSR
2fa26fe 
The TCSR clkref_en clocks gate the QREF block which provides reference
clocks to the PCIe PHYs. Wire up the LDO supplies required by the QREF
and refgen blocks on the CRD board.

Link: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-6-776f2811b7af@oss.qualcomm.com/
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qianyu-qcom
FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies
b936f5f 
Wire up the LDO supplies required by the QREF and refgen blocks on Purwa
and Hamoa boards. Purwa's QREF topology is same as Hamoa's, so it reuses
the same qcom,x1e80100-tcsr compatible and supply set rather than needing
a dedicated one.

Link: https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-3-13047922a376@oss.qualcomm.com/
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qlijarvis

qlijarvis commented Jul 29, 2026

Copy link
Copy Markdown

PR #869 — validate-patch

PR: #869

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: Yes for commits 3-12 (FROMLIST); No for commits 1-2 (Revert — no lore link expected)
  2. Lore link matches PR commits: Yes — all FROMLIST commits have corresponding lore links; commit 9 has incorrect tag format (List: vs Link:)
  3. Upstream patch status: ⏳ Decision Pending — all patches have Reviewed-by: Konrad Dybcio; no merge confirmation yet (series posted July 2026, still under review)
  4. PR present in qcom-next/topics: Fail - 2/12 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #869 - "clk: qcom: Add common clkref support and migrate Glymur/Mahua/Hamoa/Purwa"
Verdict: ⚠️ PARTIAL

Summary by Commit

Commit 1/12: Revert "WORKAROUND: arm64: dts: qcom: Add qref supply for PCIe PHYs"

  • Type: Revert of vendor workaround
  • Lore link: No (revert commits don't require lore links)
  • Commit message: ✅ Correct revert format with SHA reference
  • Authorship: ✅ Qiang Yu
  • Diff: ✅ Removes vdda-qref-supply lines from hamoa-iot-som.dtsi
  • Integration status: ⚠️ Missing from qcom-next and topics (per integration_presence_report.md)

Commit 2/12: Revert "WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 qref supplies"

  • Type: Revert of vendor workaround
  • Lore link: No (revert commits don't require lore links)
  • Commit message: ✅ Correct revert format with SHA reference
  • Authorship: ✅ Qiang Yu
  • Diff: ✅ Removes x1e80100_qmp_gen3x2_pciephy_cfg and reverts vreg_list changes
  • Integration status: ✅ Present in qcom-next

Commit 3/12: FROMLIST: clk: qcom: Add generic clkref_en support

Commit 4/12: FROMLIST: clk: qcom: tcsrcc-glymur: Add regulator

Commit 5/12: FROMLIST: clk: qcom: tcsrcc-glymur: Add Mahua QREF

Commit 6/12: FROMLIST: dt-bindings: clock: qcom: Move x1e80100 TCSR

Commit 7/12: FROMLIST: clk: qcom: tcsrcc-x1e80100: Migrate to

Commit 8/12: FROMLIST: dt-bindings: clock: qcom: Move glymur TCSR to

Commit 9/12: FROMLIST: dt-bindings: clock: qcom,glymur-tcsr: Add

Commit 10/12: FROMLIST: arm64: dts: qcom: glymur-crd: Add refgen

Commit 11/12: FROMLIST: arm64: dts: qcom: glymur: Add QREF regulator

Commit 12/12: FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF

Issues Found

  1. Commit 9/12: Uses "List:" tag instead of "Link:" — kernel convention requires "Link:" for lore references
  2. Commit 1/12: Missing from qcom-next and topics — revert may need to be synchronized with upstream acceptance
  3. Commit 10/12: Missing from qcom-next and topics — DTS change not yet integrated

Verdict

⚠️ Request minor fix before merge:

  1. Fix commit 9/12: Change "List:" to "Link:" in the commit message
  2. Verify commits 1/12 and 10/12 integration status — these are missing from qcom-next/topics

All other commits are correctly formatted, match their lore sources, and are present in qcom-next or topics.

Final Summary

  1. Lore link present: Yes for commits 3-12 (FROMLIST); No for commits 1-2 (Revert — no lore link expected)
  2. Lore link matches PR commits: Yes — all FROMLIST commits have corresponding lore links; commit 9 has incorrect tag format (List: vs Link:)
  3. Upstream patch status: ⏳ Decision Pending — all patches have Reviewed-by: Konrad Dybcio; no merge confirmation yet (series posted July 2026, still under review)
  4. PR present in qcom-next/topics: Partial — 10/12 commits present; commits 1/12 and 10/12 missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 07f50dc44eddcf748a99d1a7523a466438bfffa6
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/12 [PATCH 01/12] Revert "WORKAROUND: arm64: dts: qcom: Add qref supply missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/12 [PATCH 02/12] Revert "WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
3/12 [PATCH 03/12] FROMLIST: clk: qcom: Add generic clkref_en support present - exact patch-id match at bd7d807 skipped - not checked because qcom-next already contains the change present
4/12 [PATCH 04/12] FROMLIST: clk: qcom: tcsrcc-glymur: Add regulator partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
5/12 [PATCH 05/12] FROMLIST: clk: qcom: tcsrcc-glymur: Add Mahua QREF present - exact patch-id match at 3de5c4a skipped - not checked because qcom-next already contains the change present
6/12 [PATCH 06/12] FROMLIST: dt-bindings: clock: qcom: Move x1e80100 TCSR present - exact patch-id match at 4a31663 skipped - not checked because qcom-next already contains the change present
7/12 [PATCH 07/12] FROMLIST: clk: qcom: tcsrcc-x1e80100: Migrate to present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
8/12 [PATCH 08/12] FROMLIST: dt-bindings: clock: qcom: Move glymur TCSR to present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
9/12 [PATCH 09/12] FROMLIST: dt-bindings: clock: qcom,glymur-tcsr: Add present - exact patch-id match at 60b46c8 skipped - not checked because qcom-next already contains the change present
10/12 [PATCH 10/12] FROMLIST: arm64: dts: qcom: glymur-crd: Add refgen missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
11/12 [PATCH 11/12] FROMLIST: arm64: dts: qcom: glymur: Add QREF regulator present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
12/12 [PATCH 12/12] FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF missing - no subject, patch-id, or full tree-content match found present - all checked added lines are present present

Final Status

overall_status: FAIL
present_commits: 10/12
partial_commits: 0/12
missing_commits: 2/12
topics_checked_for_commits: 4/12
final_summary: PR present in qcom-next/topics: Fail - 2/12 commit(s) are missing from both qcom-next and topics

@qlijarvis

qlijarvis commented Jul 29, 2026

Copy link
Copy Markdown

PR #869 — checker-log-analyzer

PR: #869
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30429118973

Checker Result Summary
Checker Result Summary
checkpatch ❌ 2 warnings in commit e452b1f
dt-binding-check ✅ All binding checks passed
dtb-check ❌ Missing required properties in glymur-crd.dtb
sparse-check ✅ Passed (pre-existing imagination driver errors unrelated to PR)
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 5 failures: 2 missing prefix, 1 missing Link, 3 content mismatches
tag-check ❌ 2 commits missing required prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #869 - QREF regulator support for Glymur/Hamoa/Purwa
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/30429118973

Checker Result Summary
checkpatch ❌ 2 warnings in commit e452b1f
dt-binding-check ✅ All binding checks passed
dtb-check ❌ Missing required properties in glymur-crd.dtb
sparse-check ✅ Passed (pre-existing imagination driver errors unrelated to PR)
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 5 failures: 2 missing prefix, 1 missing Link, 3 content mismatches
tag-check ❌ 2 commits missing required prefix

❌ checkpatch

Root cause: Commit e452b1f uses List: instead of Link: trailer, which is not recognized by kernel conventions.

Failure details:

Commit e452b1f8e6f3 ("FROMLIST: dt-bindings: clock: qcom,glymur-tcsr: Add mahua support")
WARNING: Unknown link reference 'List:', use 'Link:' or 'Closes:' instead
#15: 
List: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-2-776f2811b7af@oss.qualcomm.com/

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#15: 
List: https://lore.kernel.org/all/20260702-tcsr_qref_0702-v7-2-776f2811b7af@oss.qualcomm.com/

Fix: Change List: to Link: in the commit message.

git rebase -i <base_sha>   # mark commit e452b1f8e6f3 as 'edit'
git commit --amend         # change "List:" to "Link:" in the commit body
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git d9ebca924ccc..77e582b82262

❌ dtb-check

Root cause: The new qcom,glymur-tcsr binding declares many regulator supplies as required, but glymur-crd.dtb only provides a subset of them.

Failure details:

glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrpt0-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrpt1-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrpt2-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrpt3-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrpt4-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrx0-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrx1-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrx2-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrx4-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qrefrx5-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qreftx0-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qreftx0-1p2-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-qreftx1-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-refgen3-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-refgen3-1p2-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-refgen4-0p9-supply' is a required property
glymur-crd.dtb: clock-controller@1fd5044 (qcom,glymur-tcsr): 'vdda-refgen4-1p2-supply' is a required property

glymur-crd.dtb: phy@1b50000 (qcom,glymur-qmp-gen5x4-pcie-phy): 'vdda-refgen0p9-supply', 'vdda-refgen1p2-supply' do not match any of the regexes: '^pinctrl-[0-9]+$'

Fix: Either:

  1. Add all missing regulator supplies to arch/arm64/boot/dts/qcom/glymur-crd.dts, or
  2. Make these properties optional (not required) in the binding YAML Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml if they are truly optional for some board configurations.

Additionally, the PCIe PHY binding needs to be updated to allow vdda-refgen0p9-supply and vdda-refgen1p2-supply properties.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/glymur-crd.dtb

❌ check-patch-compliance

Root cause: Multiple compliance issues across 5 commits.

Issue 1: Missing prefix on Revert commits (2 commits)

Failure details:

Checking commit: Revert "WORKAROUND: arm64: dts: qcom: Add qref supply for PCIe PHYs"
Commit summary does not start with a required prefix

Checking commit: Revert "WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 qref supplies"
Commit summary does not start with a required prefix

Fix: Add a prefix before Revert. Since these are reverting workarounds, use UPSTREAM: or FROMLIST: prefix:

git rebase -i <base_sha>   # mark commits 37751e18 and a31327c6 as 'reword'
# Change subjects to:
UPSTREAM: Revert "WORKAROUND: arm64: dts: qcom: Add qref supply for PCIe PHYs"
UPSTREAM: Revert "WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 qref supplies"

Issue 2: Missing Link trailer (1 commit)

Failure details:

Checking commit: FROMLIST: dt-bindings: clock: qcom,glymur-tcsr: Add mahua support
No 'Link' found in commit message

Fix: This is the same commit that has List: instead of Link: (caught by checkpatch). Change List: to Link:.

Issue 3: Content mismatch with upstream (3 commits)

Failure details:

Checking commit: FROMLIST: clk: qcom: tcsrcc-glymur: Add regulator supplies and migrate to clk_ref helper
Change is different from the one mentioned in Link

Checking commit: FROMLIST: arm64: dts: qcom: glymur-crd: Add refgen supplies for PCIe PHY on Glymur
Change is different from the one mentioned in Link

Checking commit: FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies
Change is different from the one mentioned in Link

Fix: Verify whether the differences are:

  • Context-only shifts (acceptable, no action needed)
  • Legitimate adaptations for the target tree (document in commit message)
  • Missing or extra hunks (sync with upstream or split into separate commits)

To investigate:

# For each commit, fetch the upstream version and compare:
b4 am --single-message -C -l -3 <link-from-commit-message> -o /tmp/upstream
git format-patch -1 <commit-sha> --stdout > /tmp/local.patch
# Compare the diff hunks manually

Reproduce locally:

./scripts/check-patch-compliance.sh <base_sha> <head_sha>

❌ tag-check

Root cause: Two Revert commits do not start with a required subject prefix.

Failure details:

Commit 37751e18 ("Revert "WORKAROUND: arm64: dts: qcom: Add qref supply for PCIe PHYs""):
  subject line does not start with a required prefix.

Commit a31327c6 ("Revert "WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 qref supplies""):
  subject line does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require one of:
FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix: Add UPSTREAM: or FROMLIST: prefix before Revert:

git rebase -i <base_sha>   # mark commits as 'reword'
# Change subjects to:
UPSTREAM: Revert "WORKAROUND: arm64: dts: qcom: Add qref supply for PCIe PHYs"
UPSTREAM: Revert "WORKAROUND: phy: qcom: qmp-pcie: add x1e80100 qref supplies"

Verdict

Fix 6 blockers before merge:

  1. ❌ Revert commits missing prefix (2 commits) — Add UPSTREAM: prefix before Revert
  2. ❌ List: should be Link: (1 commit e452b1f) — Change trailer tag
  3. ❌ Missing required DT properties (glymur-crd.dtb) — Add missing regulator supplies or make them optional in binding
  4. ⚠️ Content mismatch with upstream (3 commits) — Verify and document differences
  5. ⚠️ PCIe PHY binding — Update to allow new refgen supply properties

The checkpatch, tag-check, and check-patch-compliance prefix/Link issues are straightforward fixes (reword commits). The dtb-check failure requires either adding DT properties or adjusting the binding schema. The content-mismatch warnings need investigation to determine if they represent legitimate adaptations or unintended divergence from upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardosalveti Ricardo Salveti (ricardosalveti) Awaiting requested review from ricardosalveti ricardosalveti was automatically assigned from qualcomm-linux/qualcomm-kernel-maint
@trsoni Trilok Soni (trsoni) Awaiting requested review from trsoni trsoni was automatically assigned from qualcomm-linux/qualcomm-kernel-maint
@jingyiwang42 jingyiwang42 Awaiting requested review from jingyiwang42 jingyiwang42 was automatically assigned from qualcomm-linux/qualcomm-kernel-maint

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qianyu-qcom @qlijarvis