PCIe M.2 BT PCI IDs and lemans-evk connector DTS - #846
Conversation
…luetooth WCN6855 is a Qualcomm Wi-Fi/BT combo chip that uses PCI device ID 0x1103. Add it to pwrseq_m2_pci_ids[] alongside the existing 0x1107 (WCN7850) entry, so that the pwrseq-pcie-m2 driver creates a Bluetooth serdev device for WCN6855 cards inserted into PCIe M.2 Key E connectors. Reviewed-by: Manivannan Sadhasivam <mani@kernel.org> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com> Link: https://patch.msgid.link/20260608091702.3797437-2-wei.deng@oss.qualcomm.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
PR #846 — validate-patchPR: #846
Final Summary
|
PR #846 — checker-log-analyzerPR: #846
Detailed report: Full report
|
1ddbce6 to
6eabf23
Compare
…g order Sort the entries in pwrseq_m2_pci_ids[] by device ID in ascending order: 0x1103 (WCN6855) before 0x1107 (WCN7850). Fixes: 3a94536 ("UPSTREAM: power: sequencing: pcie-m2: Add PCI ID 0x1103 for WCN6855 Bluetooth") Reviewed-by: Manivannan Sadhasivam <mani@kernel.org> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com> Link: https://patch.msgid.link/20260617143055.820096-1-wei.deng@oss.qualcomm.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Add the Qualcomm QCC2072 Bluetooth device (PCI ID 0x1112) to the pwrseq_m2_pci_ids table so the M.2 power sequencer can create the serdev node for its BT interface on enumeration. Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com> Link: https://patch.msgid.link/20260703-eliza_evk-v1-3-7624440bd76d@oss.qualcomm.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Add 'compatible = "pciclass,0604"' to the pcieport0 node in lemans.dtsi to allow the PCI subsystem to associate the DT node with the PCI-to-PCI bridge device. This is required for downstream DT nodes (such as M.2 connectors described as graph endpoints of the Root Port) to be matched to PCI devices. Link: https://lore.kernel.org/r/20260622-v3-lemans-split-v3-1-d26bb22594e3@oss.qualcomm.com Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
…nnector The lemans EVK has the PCIe M.2 Mechanical Key E connector to connect wireless connectivity cards over PCIe and UART interfaces. Hence, describe the connector node and link it with the PCIe 0 Root Port and UART17 nodes through graph port/endpoint. The M.2 Key E connector is powered by a 3.3V fixed regulator (vreg_wcn_3p3) which is sourced from the board's 12V DC input rail (vreg_dcin_12v). Both regulators are always-on and are required by the pcie-m2-e-connector binding. Also add the serial1 = &uart17 alias, which is required for the Bluetooth serdev device to be enumerated on the UART17 interface. Link: https://lore.kernel.org/r/20260622-v3-lemans-split-v3-2-d26bb22594e3@oss.qualcomm.com Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
6eabf23 to
56bb01f
Compare
|
Hi reviewers, All 3 CI failures in run 1. 2. 3. All 5 commits are upstream-reviewed. Requesting override on 1 & 2, and a dtschema bump on the runner for 3. Thanks! |
PR #846 — validate-patchPR: #846
Final Summary
Overall verdict: ❌ FAIL — Commit 5/5 diverges significantly from its lore source and removes functionality (bluetooth node) not documented in the upstream patch.
|
PR #846 — checker-log-analyzerPR: #846
Detailed report: Full report
|
|
checkpatch | ❌ | 1 warning: undocumented vendor prefix "pciclass" weiden (@WeiDeng-weiden) please check this failure. |
|
Hi Salendarsingh Gaud (@sgaud-quic), The |
|
Changes look good to me. |
Test Matrix
|
Komal Bajaj (@Komal-Bajaj) please update dtschema to latest in kmake-image |
PR #846 — validate-patchPR: #846
Final Summary
|
PR #846 — validate-patchPR: #846
Final Summary
|
PR #846 — checker-log-analyzerPR: #846
Detailed report: Full report
|
PR #846 — validate-patchPR: #846
Final Summary
|
PR #846 — checker-log-analyzerPR: #846
Detailed report: Full report
|
PR #846 — validate-patchPR: #846
Final Summary
|
PR #846 — checker-log-analyzerPR: #846
Detailed report: Full report
|
|
|
Salendarsingh Gaud (@sgaud-quic) |
|
Shiraz Hashim (@shashim-quic) please confirm if this can be overridden ? |
|
weiden (@WeiDeng-weiden) please add mainline PR/commits for below commits in CR : |
qualcomm-linux/kernel-topics#1411 |
weiden (@WeiDeng-weiden) add this PR to CR as well |
Added, please. |
1ccd895
into
qualcomm-linux:qcom-6.18.y
|
Change task cannot be moved to Dev Complete CR: 4550026 The change task for this CR cannot be automatically moved to Dev Complete due to the error above. Please resolve the issue mentioned in the error and manually change the change task status to Dev Complete in Orbit. |
Follow-up to #614, adding Bluetooth PCI device IDs for WCN6855 and
QCC2072 chips, and enabling the PCIe M.2 Key E connector on lemans EVK.
PCI device IDs (pwrseq-pcie-m2 driver):
0x1103for WCN6855 (NFA765A) UART Bluetooth, so the drivercreates a Bluetooth serdev device when a WCN6855 M.2 card is inserted
pwrseq_m2_pci_ids[]entries in ascending order by device ID0x1112for QCC2072 (Cologne) UART Bluetoothlemans-evk DTS:
compatible = "pciclass,0604"to the PCIe Root Port node inlemans.dtsi, required forpci_pwrctrlto associate the DT nodewith the PCI-to-PCI bridge device
lemans-evk.dts: connectornode, PCIe and UART graph endpoints, regulator properties; also
replaces the static
bluetooth {}node with a dynamic OF graphendpoint so the pwrseq driver can create the serdev at runtime
CRs-Fixed: 4550026