Skip to content

ath12k: fix peer_id usage in normal RX path#524

Open
MilanoPipo wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
MilanoPipo:channel-177
Open

ath12k: fix peer_id usage in normal RX path#524
MilanoPipo wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
MilanoPipo:channel-177

Conversation

@MilanoPipo
Copy link
Copy Markdown
Contributor

@MilanoPipo MilanoPipo commented Apr 30, 2026 •
edited by sgaud-quic
Loading

FROMLIST: wifi: ath12k: fix peer_id usage in normal RX path
CRs-Fixed: 4473306
Link: https://lore.kernel.org/all/20260427-ath12k-fix-peer-id-source-v1-1-b5f701fb8e88@oss.qualcomm.com

FROMLIST: wifi: ath12k: add channel 177 to the 5 GHz channel list
CRs-Fixed: 4435878
Link: https://lore.kernel.org/all/20260415063857.2462256-1-yintang@qti.qualcomm.com

MilanoPipo and others added 2 commits April 29, 2026 20:06
@MilanoPipo
FROMLIST: wifi: ath12k: add channel 177 to the 5 GHz channel list
b4fb515 
Add support for 5 GHz channel 177 with a center frequency of 5885 MHz and
Operating Class 125 per IEEE Std 802.11-2024 Table E-4.

Channels 169, 173, and 177 are in the 5.9 GHz band and must be disabled
when 5.9 GHz service bit is not supported. The 5.9 GHz band is only permitted
for WLAN operation under FCC regulations.

CRs-Fixed: 4435878
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3
Link: https://lore.kernel.org/all/20260415063857.2462256-1-yintang@qti.qualcomm.com
Signed-off-by: Yingying Tang <yingying.tang@oss.qualcomm.com>
@MilanoPipo
FROMLIST: wifi: ath12k: fix peer_id usage in normal RX path
b2f828a 
ath12k_dp_rx_deliver_msdu() currently uses hal_rx_desc_data::peer_id
parsed from mpdu_start descriptor to do peer lookup. However In an A-MSDU
aggregation scenario, hardware only populates mpdu_start descriptor for
the first sub-msdu, but not the following ones. In that case peer_id could
be invalid, leading to peer lookup failure:

ath12k_wifi7_pci 0000:06:00.0: rx skb 00000000c391c041 len 1532 peer (null) 0 ucast sn 0 eht320 rate_idx 12 vht_nss 2 freq 6105 band 3 flag 0x40d1a fcs-err 0 mic-err 0 amsdu-more 0

As a result pubsta is NULL and parts of ieee80211_rx_status structure are
left uninitialized, which may cause unexpected behavior.

Fix it by switching the normal RX path to use ath12k_skb_rxcb::peer_id
which is parsed from REO ring's rx_mpdu_desc and is always valid.

hal_rx_desc_data::peer_id is still used in
ath12k_wifi7_dp_rx_frag_h_mpdu(), which is safe since A-MSDU
aggregation does not occur for fragmented frames. Similarly,
ath12k_skb_rxcb::peer_id may be overwritten by hal_rx_desc_data::peer_id
in ath12k_wifi7_dp_rx_h_mpdu(), which only handles non-aggregated
multicast/broadcast traffic.

CRs-Fixed4473306
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3
Link: https://lore.kernel.org/all/20260427-ath12k-fix-peer-id-source-v1-1-b5f701fb8e88@oss.qualcomm.com
Fixes: 11157e0 ("wifi: ath12k: Use ath12k_dp_peer in per packet Tx & Rx paths")
Signed-off-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
@MilanoPipo MilanoPipo changed the title Channel 177 ath12k: fix peer_id usage in normal RX path Apr 30, 2026
@qcomlnxci
Copy link
Copy Markdown

qcomlnxci commented May 8, 2026

Test Matrix

Test Case glymur-crd kaanapali-mtp lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 sm8750-mtp x1e80100-crd
0_qcom-next-ci-premerge-tests ◻️ ◻️ ❌ Fail ◻️ ◻️ ❌ Fail ◻️ ◻️ ◻️ ◻️
BT_FW_KMD_Service ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
BT_ON_OFF ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
BT_SCAN ◻️ ◻️ ✅ Pass ❌ Fail ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
CPUFreq_Validation ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
CPU_affinity ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
DSP_AudioPD ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
Ethernet ◻️ ◻️ ⚠️ skip ⚠️ skip ◻️ ⚠️ skip ⚠️ skip ◻️ ◻️ ◻️
Freq_Scaling ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
GIC ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
IPA ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
Interrupts ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
OpenCV ◻️ ◻️ ✅ Pass ⚠️ skip ◻️ ✅ Pass ⚠️ skip ◻️ ◻️ ◻️
PCIe ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
Probe_Failure_Check ◻️ ◻️ ❌ Fail ❌ Fail ◻️ ❌ Fail ✅ Pass ◻️ ◻️ ◻️
RMNET ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
UFS_Validation ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
USBHost ◻️ ◻️ ❌ Fail ✅ Pass ◻️ ❌ Fail ✅ Pass ◻️ ◻️ ◻️
WiFi_Firmware_Driver ◻️ ◻️ ❌ Fail ⚠️ skip ◻️ ✅ Pass ⚠️ skip ◻️ ◻️ ◻️
WiFi_OnOff ◻️ ◻️ ✅ Pass ❌ Fail ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
adsp_remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
cdsp_remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
gpdsp_remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ⚠️ skip ✅ Pass ◻️ ◻️ ◻️
hotplug ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
irq ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
kaslr ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
pinctrl ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
qcom_hwrng ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
rngtest ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
shmbridge ◻️ ◻️ ❌ Fail ✅ Pass ◻️ ❌ Fail ✅ Pass ◻️ ◻️ ◻️
smmu ◻️ ◻️ ❌ Fail ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
watchdog ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
wpss_remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️

@qcomlnxci
Copy link
Copy Markdown

qcomlnxci commented May 8, 2026

Test jobs on b2f828a

@qswat-orbit-external
Copy link
Copy Markdown

qswat-orbit-external Bot commented May 12, 2026

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4435878 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4435878

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qcomlnxci
Copy link
Copy Markdown

qcomlnxci commented May 12, 2026

Test jobs on b2f828a

@qcomlnxci
Copy link
Copy Markdown

qcomlnxci commented May 12, 2026

Test Matrix

Test Case glymur-crd kaanapali-mtp lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 sm8750-mtp x1e80100-crd
0_qcom-next-ci-premerge-tests ◻️ ◻️ ❌ Fail ◻️ ◻️ ❌ Fail ◻️ ◻️ ◻️ ◻️
BT_FW_KMD_Service ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
BT_ON_OFF ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
BT_SCAN ◻️ ◻️ ✅ Pass ❌ Fail ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
CPUFreq_Validation ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
CPU_affinity ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
DSP_AudioPD ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
Ethernet ◻️ ◻️ ⚠️ skip ⚠️ skip ◻️ ⚠️ skip ⚠️ skip ◻️ ◻️ ◻️
Freq_Scaling ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
GIC ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
IPA ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
Interrupts ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
OpenCV ◻️ ◻️ ✅ Pass ⚠️ skip ◻️ ✅ Pass ⚠️ skip ◻️ ◻️ ◻️
PCIe ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
Probe_Failure_Check ◻️ ◻️ ❌ Fail ❌ Fail ◻️ ❌ Fail ✅ Pass ◻️ ◻️ ◻️
RMNET ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
UFS_Validation ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
USBHost ◻️ ◻️ ❌ Fail ✅ Pass ◻️ ❌ Fail ✅ Pass ◻️ ◻️ ◻️
WiFi_Firmware_Driver ◻️ ◻️ ❌ Fail ⚠️ skip ◻️ ✅ Pass ⚠️ skip ◻️ ◻️ ◻️
WiFi_OnOff ◻️ ◻️ ✅ Pass ❌ Fail ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
adsp_remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
cdsp_remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
gpdsp_remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ⚠️ skip ✅ Pass ◻️ ◻️ ◻️
hotplug ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
irq ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
kaslr ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
pinctrl ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
qcom_hwrng ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
rngtest ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
shmbridge ◻️ ◻️ ❌ Fail ✅ Pass ◻️ ❌ Fail ✅ Pass ◻️ ◻️ ◻️
smmu ◻️ ◻️ ❌ Fail ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
watchdog ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️
wpss_remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️ ◻️ ◻️

@qcomlnxci
Copy link
Copy Markdown

qcomlnxci commented May 12, 2026

Test Matrix

Test Case glymur-crd kaanapali-mtp lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 sm8750-mtp x1e80100-crd
0_qcom-next-ci-premerge-tests ◻️ ◻️ ❌ Fail ◻️ ❌ Fail ❌ Fail ◻️ ❌ Fail ◻️ ◻️
BT_FW_KMD_Service ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
BT_ON_OFF ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
BT_SCAN ◻️ ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
CPUFreq_Validation ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
CPU_affinity ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
DSP_AudioPD ◻️ ◻️ ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ◻️ ⚠️ skip ◻️ ◻️
Ethernet ◻️ ◻️ ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ◻️ ⚠️ skip ◻️ ◻️
Freq_Scaling ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
GIC ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
IPA ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
Interrupts ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
OpenCV ◻️ ◻️ ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
PCIe ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
Probe_Failure_Check ◻️ ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️ ❌ Fail ◻️ ◻️
RMNET ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
UFS_Validation ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
USBHost ◻️ ◻️ ❌ Fail ✅ Pass ❌ Fail ❌ Fail ◻️ ❌ Fail ◻️ ◻️
WiFi_Firmware_Driver ◻️ ◻️ ❌ Fail ⚠️ skip ◻️ ✅ Pass ◻️ ✅ Pass ◻️ ◻️
WiFi_OnOff ◻️ ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
adsp_remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ❌ Fail ◻️ ◻️
cdsp_remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ❌ Fail ◻️ ◻️
gpdsp_remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ◻️ ❌ Fail ◻️ ◻️
hotplug ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
irq ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
kaslr ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
pinctrl ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
qcom_hwrng ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ❌ Fail ◻️ ◻️
rngtest ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
shmbridge ◻️ ◻️ ❌ Fail ✅ Pass ❌ Fail ❌ Fail ◻️ ❌ Fail ◻️ ◻️
smmu ◻️ ◻️ ❌ Fail ✅ Pass ❌ Fail ✅ Pass ◻️ ❌ Fail ◻️ ◻️
watchdog ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️
wpss_remoteproc ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ◻️

@qcomlnxci
Copy link
Copy Markdown

qcomlnxci commented May 12, 2026

Test jobs on b2f828a

@qswat-orbit-external
Copy link
Copy Markdown

qswat-orbit-external Bot commented May 13, 2026

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4435878 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4435878

Please ensure the CR has a change task associated with at least one of the entities for this branch.

1 similar comment
@qswat-orbit-external
Copy link
Copy Markdown

qswat-orbit-external Bot commented May 15, 2026

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4435878 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4435878

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@sgaud-quic
Copy link
Copy Markdown
Contributor

sgaud-quic commented May 16, 2026

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4435878 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4435878

Please ensure the CR has a change task associated with at least one of the entities for this branch.

Please add proper change task to CR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shashim-quic shashim-quic shashim-quic approved these changes

@Komal-Bajaj Komal-Bajaj Awaiting requested review from Komal-Bajaj Komal-Bajaj was automatically assigned from qualcomm-linux/qualcomm-kernel-maint

@sgaud-quic sgaud-quic Awaiting requested review from sgaud-quic sgaud-quic was automatically assigned from qualcomm-linux/qualcomm-kernel-maint

+1 more reviewer

@miaoqing-quic miaoqing-quic miaoqing-quic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MilanoPipo @qcomlnxci @sgaud-quic @shashim-quic @miaoqing-quic