Skip to content

chore: update .gitignore and add go.sum#619

Merged
YangSen-qn merged 1 commit intoqiniu:masterfrom
YangSen-qn:master
Apr 13, 2026
Merged

chore: update .gitignore and add go.sum#619
YangSen-qn merged 1 commit intoqiniu:masterfrom
YangSen-qn:master

Conversation

@YangSen-qn
Copy link
Copy Markdown
Collaborator

  • 添加 .claude/settings.local.json 等 AI 工具相关忽略规则
  • 添加 code-gen Go 项目依赖校验和文件

@qiniu-prow qiniu-prow bot added the size/M label Apr 13, 2026
Copy link
Copy Markdown

@xgopilot xgopilot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

This PR has two substantive concerns: a semantically incorrect fallback in Configuration.clone(), and incomplete ignore patterns for AI tool directories that could leave sensitive config files unprotected.

Comment thread src/main/java/com/qiniu/storage/Configuration.java Outdated
Comment thread .gitignore Outdated
Comment thread .gitignore
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .gitignore file to exclude AI tool configurations and adds a go.sum file for dependency management. It also modifies the clone() method in Configuration.java to return 'this' instead of null in a catch block. Feedback indicates that returning 'this' violates the Java clone contract and suggests throwing an AssertionError instead, while also noting that this change appears unrelated to the rest of the PR.

Comment thread src/main/java/com/qiniu/storage/Configuration.java Outdated
- 添加 .claude/settings.local.json 等 AI 工具相关忽略规则
- 添加 code-gen Go 项目依赖校验和文件
- 修复 Configuration.clone() 返回 this 而非 null
@YangSen-qn
Copy link
Copy Markdown
Collaborator Author

/test qiniu-java-sdk11-presubmit-integration-test

@YangSen-qn YangSen-qn merged commit 388d237 into qiniu:master Apr 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant