NXP backend: Fix NeutronConfig copy callback signature to match the d… - #22439
Open
jirioc wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22439
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f51ddda with merge base 55a969e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
jirioc
force-pushed
the
EIEX-1071-upstream-fix-neutronconfig-copy-callback-signature-to-match-the-driver-header
branch
from
September 5, 2026 07:07
fd7f8ad to
9e0848e
Compare
jirioc
added
the
module: nxp
jirioc
force-pushed
the
EIEX-1071-upstream-fix-neutronconfig-copy-callback-signature-to-match-the-driver-header
branch
from
September 7, 2026 06:47
9e0848e to
f51ddda
Compare
Collaborator
Author
|
@pytorchbot label "release notes: nxp" |
pytorch-bot
Bot
added
the
release notes: nxp
|
|
||
| # Build | ||
| cmake -DEXECUTORCH_BUILD_NXP_NEUTRON=ON -Bcmake-out . | ||
| cmake -DEXECUTORCH_BUILD_NXP_NEUTRON=ON -DCMAKE_CXX_FLAGS="-DEXTERNAL_MEM" -Bcmake-out . |
Collaborator
There was a problem hiding this comment.
Instead of editing the CMAKE_CXX_FLAGS, introduce a configuration option into Neutron Backend, allowing the External Memory for eIQ Neutron NPU.
| // For a model converted with --fetch_constants_to_sram. | ||
| void copy(void* dst, const void* src, uint32_t size, uint32_t channel) { | ||
| // cppcheck-suppress constParameterCallback | ||
| void copy(void* dst, void* src, uint32_t size, uint32_t channel) { |
Collaborator
There was a problem hiding this comment.
void copy(void* dst, const void* src, uint32_t size, uint32_t channels)shall avoid the CPPCHECK reported issue.
Collaborator
Author
There was a problem hiding this comment.
Const needs to be removed in order to be compatible with the NeutronDriver.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix NeutronConfig copy callback signature to match the driver header.
Test plan
Modified the nxp-build-test to test this.
cc @robert-kalmar @JakeStevens @digantdesai @rascani