Arm backend: Add TOSA PAD dialect op#17940
Open
oscarandersson8218 wants to merge 3 commits intopytorch:mainfrom
Open
Arm backend: Add TOSA PAD dialect op#17940oscarandersson8218 wants to merge 3 commits intopytorch:mainfrom
oscarandersson8218 wants to merge 3 commits intopytorch:mainfrom
Conversation
Adds new TOSA dialect op for PAD. aten.constant_pad_nd nodes are replaced by tosa.PAD in RewritePadPass. op_constant_pad_nd node visitor is replaced by a simpler node vistior for tosa.pad. Co-authored-by: Per Åstrand <per.astrand@arm.com> Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: I9ddaa422d373f9a2a750429243ae39f8b8ffddf0
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17940
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 3 Unrelated FailuresAs of commit 679c32e with merge base 6b5283c ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
|
Hi @SS-JIA this adds a file but I also spot |
Collaborator
Author
|
cortex_m_size_test failures are not introduced by this patch. Probably introduced by #17326. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new TOSA dialect op for PAD. aten.constant_pad_nd nodes are replaced by tosa.PAD in RewritePadPass. op_constant_pad_nd node visitor is replaced by a simpler node vistior for tosa.PAD.
cc @digantdesai @SS-JIA @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell