Skip to content

Arm backend: Add TOSA PAD dialect op#17940

Open
oscarandersson8218 wants to merge 3 commits intopytorch:mainfrom
oscarandersson8218:tosa_dialect_pad
Open

Arm backend: Add TOSA PAD dialect op#17940
oscarandersson8218 wants to merge 3 commits intopytorch:mainfrom
oscarandersson8218:tosa_dialect_pad

Conversation

@oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Mar 5, 2026

Adds new TOSA dialect op for PAD. aten.constant_pad_nd nodes are replaced by tosa.PAD in RewritePadPass. op_constant_pad_nd node visitor is replaced by a simpler node vistior for tosa.PAD.

cc @digantdesai @SS-JIA @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell

Adds new TOSA dialect op for PAD. aten.constant_pad_nd nodes are
replaced by tosa.PAD in RewritePadPass. op_constant_pad_nd node visitor
is replaced by a simpler node vistior for tosa.pad.

Co-authored-by: Per Åstrand <per.astrand@arm.com>
Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: I9ddaa422d373f9a2a750429243ae39f8b8ffddf0
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17940

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 3 Unrelated Failures

As of commit 679c32e with merge base 6b5283c (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 5, 2026
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Mar 5, 2026
@zingo
Copy link
Collaborator

zingo commented Mar 6, 2026

Hi @SS-JIA this adds a file but I also spot srcs = glob(["op_*.py", "ops_*.py"]), so I think it should be fine.

@oscarandersson8218
Copy link
Collaborator Author

cortex_m_size_test failures are not introduced by this patch. Probably introduced by #17326.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants