Skip to content

Remove type dispatch for quantized_conv1d ops#17939

Open
mcremon-meta wants to merge 1 commit intomainfrom
export-D95277804
Open

Remove type dispatch for quantized_conv1d ops#17939
mcremon-meta wants to merge 1 commit intomainfrom
export-D95277804

Conversation

@mcremon-meta
Copy link
Contributor

Summary:
Remove typed quantized_conv1d operator variants and their implementations to start fresh. This removes:

  • Type dispatch logic from type_dispatch.py
  • Type dispatch tests from test_type_dispatch_passes.py
  • Kernel registrations from functions.yaml and functions_hifi.yaml
  • Operator definitions from ops_registrations.py
  • Reference implementations from ref_implementations.py
  • C++ implementations from generic and HiFi operators
  • Jarvis custom op definitions and argument checks

Differential Revision: D95277804

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17939

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 12 Pending, 3 Unrelated Failures

As of commit cad7421 with merge base eb77ed4 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 5, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Mar 5, 2026

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95277804.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

meta-codesync bot pushed a commit that referenced this pull request Mar 5, 2026
Summary:

Remove typed quantized_conv1d operator variants and their implementations to start fresh. This removes:
- Type dispatch logic from type_dispatch.py
- Type dispatch tests from test_type_dispatch_passes.py
- Kernel registrations from functions.yaml and functions_hifi.yaml
- Operator definitions from ops_registrations.py
- Reference implementations from ref_implementations.py
- C++ implementations from generic and HiFi operators
- Jarvis custom op definitions and argument checks

Differential Revision: D95277804
@meta-codesync meta-codesync bot force-pushed the export-D95277804 branch from 8552ee6 to 5146539 Compare March 5, 2026 18:49
mcremon-meta added a commit that referenced this pull request Mar 5, 2026
Summary:
Pull Request resolved: #17939

Remove typed quantized_conv1d operator variants and their implementations to start fresh. This removes:
- Type dispatch logic from type_dispatch.py
- Type dispatch tests from test_type_dispatch_passes.py
- Kernel registrations from functions.yaml and functions_hifi.yaml
- Operator definitions from ops_registrations.py
- Reference implementations from ref_implementations.py
- C++ implementations from generic and HiFi operators
- Jarvis custom op definitions and argument checks

Differential Revision: D95277804
…n and tests for the main ops (#17939)

Summary:

Remove typed quantized_conv1d operator variants and their implementations to start fresh. This removes:
- Type dispatch logic from type_dispatch.py
- Type dispatch tests from test_type_dispatch_passes.py
- Kernel registrations from functions.yaml and functions_hifi.yaml
- Operator definitions from ops_registrations.py
- Reference implementations from ref_implementations.py
- C++ implementations from generic and HiFi operators
- Jarvis custom op definitions and argument checks

Reviewed By: DrJessop

Differential Revision: D95277804
@meta-codesync meta-codesync bot force-pushed the export-D95277804 branch from ee9c26a to cad7421 Compare March 6, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant