Add quantizer support for quantized_conv1d_ncl#17938
Open
mcremon-meta wants to merge 2 commits intomainfrom
Open
Add quantizer support for quantized_conv1d_ncl#17938mcremon-meta wants to merge 2 commits intomainfrom
mcremon-meta wants to merge 2 commits intomainfrom
Conversation
Summary: Remove typed quantized_conv1d operator variants and their implementations to start fresh. This removes: - Type dispatch logic from type_dispatch.py - Type dispatch tests from test_type_dispatch_passes.py - Kernel registrations from functions.yaml and functions_hifi.yaml - Operator definitions from ops_registrations.py - Reference implementations from ref_implementations.py - C++ implementations from generic and HiFi operators - Jarvis custom op definitions and argument checks Differential Revision: D95277804
Summary: Update quantizer patterns to route conv1d operations to quantized_conv1d_ncl instead of quantized_conv2d_nchw: - Conv1dPattern.replacement_op() now returns quantized_conv1d_ncl - Conv1dReluPattern0 and Conv1dReluPattern1 now return quantized_conv1d_ncl - Added fused_conv1d_relu test and _build_conv1d_relu_graph helper Differential Revision: D95279330
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17938
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New Failures, 5 Unrelated FailuresAs of commit 8588fb4 with merge base 2cb1ef5 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95279330. |
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Update quantizer patterns to route conv1d operations to quantized_conv1d_ncl instead of quantized_conv2d_nchw:
Differential Revision: D95279330