4697 - #4724
Open
micwill755 wants to merge 1 commit into
Open
4697#4724micwill755 wants to merge 1 commit into
micwill755 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
test_base_fp4_static_shapesso that it compares equivalent quantized executions.Previously, the eager reference output was generated before
mtq.quantize()was called. As a result, the test compared an FP16 eager result against an NVFP4 TensorRT result. The expected quantization loss between FP16 and NVFP4 caused the numerical check to be flaky across GPU architectures.This change moves the eager-model invocation after ModelOpt quantization. The test now compares the ModelOpt NVFP4/QDQ reference output against the TensorRT NVFP4 output.
This is consistent with the existing
test_base_fp4_dynamic_shapesandtest_nvfp4_nd_input_quantizertests, which also generate their expected outputs after quantization.Fixes #4697
Type of change
Checklist