Skip to content

Support optionally building AMD64 with tailcalling #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 8 commits into from
Mar 25, 2026
Merged

Support optionally building AMD64 with tailcalling #346

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8453063
support optionally building AMD64 with tailcalling
chris-eibl Feb 26, 2026
c49abd8
apply Steve's fix
chris-eibl Feb 26, 2026
7abd79b
Different approach. Does this work out?
chris-eibl Feb 26, 2026
6aa18d5
Update windows-release/azure-pipelines.yml
chris-eibl Feb 26, 2026
33a030b
Update windows-release/stage-build.yml
chris-eibl Feb 26, 2026
6db61cb
$(TailcallingOption) not needed anymore
chris-eibl Feb 26, 2026
873ebb7
Update windows-release/azure-pipelines.yml
chris-eibl Feb 27, 2026
0f5d98a
Tailcalling -> TailCalling
chris-eibl Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion windows-release/azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ parameters:
displayName: "Signature description"
type: string
default: '(default)'
- name: DoTailcalling
displayName: "Build AMD64 with tailcalling support (3.15 and later)"
Comment thread
chris-eibl marked this conversation as resolved.
Outdated
type: boolean
default: false
- name: DoJIT
displayName: "Build the JIT compiler (3.14 and later)"
type: boolean
Expand Down Expand Up @@ -161,7 +165,7 @@ stages:
- stage: Build
displayName: Build binaries
pool:
vmImage: ${{ parameters.vmImage }}
vmImage: ${{ if eq(parameters.DoTailcalling, 'true') }} 'windows-2025-vs2026' ${{ else }} ${{ parameters.vmImage }}
Comment thread
chris-eibl marked this conversation as resolved.
Outdated
jobs:
- template: start-arm64vm.yml
parameters:
Expand Down
9 changes: 5 additions & 4 deletions windows-release/stage-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ parameters:
DoPGOARM64: true
DoFreethreaded: false
ToBeSigned: false
DoTailcalling: false
ExtraOptions: ''
ExtraOptionsFreethreaded: '--disable-gil'

Expand Down Expand Up @@ -71,7 +72,7 @@ jobs:
Platform: x64
Configuration: Release
_HostPython: .\python
ExtraOptions: ${{ parameters.ExtraOptions }}
ExtraOptions: ${{ parameters.ExtraOptions }}${{ if eq(parameters.DoTailcalling, 'true') }} ' --tail-call-interp'
Comment thread
chris-eibl marked this conversation as resolved.
Outdated
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_amd64
${{ else }}:
Expand Down Expand Up @@ -131,7 +132,7 @@ jobs:
Platform: x64
Configuration: Release
_HostPython: .\python
ExtraOptions: ${{ parameters.ExtraOptionsFreethreaded }}
ExtraOptions: ${{ parameters.ExtraOptionsFreethreaded }}${{ if eq(parameters.DoTailcalling, 'true') }} ' --tail-call-interp'
Comment thread
chris-eibl marked this conversation as resolved.
Outdated
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_amd64_t
${{ else }}:
Expand Down Expand Up @@ -185,7 +186,7 @@ jobs:
Platform: x64
_HostPython: .\python
PythonExePattern: python.exe
ExtraOptions: ${{ parameters.ExtraOptions }}
ExtraOptions: ${{ parameters.ExtraOptions }}${{ if eq(parameters.DoTailcalling, 'true') }} ' --tail-call-interp'
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_amd64
${{ else }}:
Expand All @@ -197,7 +198,7 @@ jobs:
Platform: x64
_HostPython: .\python
PythonExePattern: python3*t.exe
ExtraOptions: ${{ parameters.ExtraOptionsFreethreaded }}
ExtraOptions: ${{ parameters.ExtraOptionsFreethreaded }}${{ if eq(parameters.DoTailcalling, 'true') }} ' --tail-call-interp'
${{ if eq(parameters.ToBeSigned, 'true') }}:
Artifact: unsigned_amd64_t
${{ else }}:
Expand Down
Loading