gh-124697: Represent inlined comprehensions as subscopes in the symbol table - #156819
Open
iritkatriel wants to merge 18 commits into
Open
gh-124697: Represent inlined comprehensions as subscopes in the symbol table#156819iritkatriel wants to merge 18 commits into
iritkatriel wants to merge 18 commits into
Conversation
iritkatriel
requested review from
JelleZijlstra,
carljm and
markshannon
as code owners
September 2, 2026 11:10
Co-authored-by: Cursor <cursoragent@cursor.com>
…l tables Co-authored-by: Cursor <cursoragent@cursor.com>
Documentation build overview
22 files changed ·
|
carljm
reviewed
Sep 2, 2026
carljm
left a comment
carljm
left a comment
Member
There was a problem hiding this comment.
This looks great! Thank you for working on this ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #124697
Inlined comprehensions are now represented in the symbol table as block of a new type
InlinedComprehensionBlock, which is a subscope of the enclosing scope and is interpreted as the delta between the containing scope and the comprehension scope. Symbol lookups thatfail in the subscope continue in the containing scope.
This moves the complexity of compiling inlined comprehensions from codegen to the symbol table
construction.
It removes the smell of the compiler modifying the symbol table in codegen.