gh-156264: add missing checks in os.chmod - #156265
Open
KowalskiThomas wants to merge 3 commits into
Open
Conversation
KowalskiThomas
force-pushed
the
kowalski/fix-add-missing-checks-in-os-chmod
branch
from
August 23, 2026 13:42
f5c1ba3 to
d40f8b5
Compare
KowalskiThomas
marked this pull request as ready for review
August 23, 2026 20:01
picnixz
reviewed
Aug 24, 2026
Comment on lines
+4121
to
+4122
| if (fd_and_follow_symlinks_invalid("chmod", path->is_fd, follow_symlinks)) | ||
| return NULL; |
Contributor
Author
There was a problem hiding this comment.
Thanks for the comment!
I believe I fixed it all, namely:
- I added curly braces to both new conditions
- I split the line you commented on so that it's not more than 79 characters
- I've also split the argument list such that it's one argument per line.
- This one I don't think the rest of (at least) this file always agrees with but... I thought I'd follow what's expected by PEP-7.
picnixz
reviewed
Aug 24, 2026
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #156264.
os.chmodis missing validation fordir_fdandfollow_symlinkswhenpathis a file descriptor #156264