gh-155726: Restore the sysconfig prefix cache in test_sysconfig - #155729
Merged
serhiy-storchaka merged 1 commit intoAug 14, 2026
Merged
Conversation
test_sysconfig_config_vars_no_prefix_cache changes sys.prefix and calls get_config_vars(), which caches the new prefix in module globals. tearDown() restored sysconfig._CONFIG_VARS, but not those globals, so the next get_config_vars() call found the cache stale and replaced _CONFIG_VARS with a new dict.
vstinner
approved these changes
Aug 13, 2026
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. It does fix the test as expected.
mbeijen
pushed a commit
to mbeijen/cpython
that referenced
this pull request
Aug 14, 2026
…pythonGH-155729) test_sysconfig_config_vars_no_prefix_cache changes sys.prefix and calls get_config_vars(), which caches the new prefix in module globals. tearDown() restored sysconfig._CONFIG_VARS, but not those globals, so the next get_config_vars() call found the cache stale and replaced _CONFIG_VARS with a new dict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save and restore
sysconfig._config_vars_cached_prefixandsysconfig._config_vars_cached_exec_prefixinTestSysConfig.