Skip to content

gh-154046: docs: fix dead link to codahale timing attacks article in secrets.rst#154047

Merged
hugovk merged 2 commits into
python:mainfrom
pranavchoudhary-tech:fix-codahale-dead-link
Jul 20, 2026
Merged

gh-154046: docs: fix dead link to codahale timing attacks article in secrets.rst#154047
hugovk merged 2 commits into
python:mainfrom
pranavchoudhary-tech:fix-codahale-dead-link

Conversation

@pranavchoudhary-tech

@pranavchoudhary-tech pranavchoudhary-tech commented Jul 19, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Fixes #154046

Replaces the dead link to codahale.com with a Wayback Machine archive link, as the original domain fails to resolve.

@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Jul 19, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jul 19, 2026
@read-the-docs-community

read-the-docs-community Bot commented Jul 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33659995 | 📁 Comparing 6c4c045 against main (c08c89a)

  🔍 Preview build  

17 files changed · ± 17 modified

± Modified

@pranavchoudhary-tech pranavchoudhary-tech changed the title docs: fix dead link to codahale timing attacks article in secrets.rst gh-154046: docs: fix dead link to codahale timing attacks article in secrets.rst Jul 19, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 19, 2026
Closed
@hugovk

hugovk commented Jul 19, 2026

Copy link
Copy Markdown
Member

Thanks for the PR.

Unfortunately the Internet Archive is rather slow, and in fact not loading for me with 503 Service Unavailable right now.

Let's first ping @codahale:

Hello! Your website is down, any chance to fix so we can continue linking to https://codahale.com/a-lesson-in-timing-attacks/? Thanks!

@StanFromIreland
StanFromIreland marked this pull request as draft July 19, 2026 08:23
@codahale

codahale commented Jul 19, 2026

Copy link
Copy Markdown

No, it’s gone forever.

@pranavchoudhary-tech
pranavchoudhary-tech marked this pull request as ready for review July 19, 2026 17:53
@pranavchoudhary-tech

pranavchoudhary-tech commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

@hugovk Since Coda Hale has confirmed the original site is 'gone forever', the Wayback Machine link in this PR is probably the best way to preserve the original context of the article! I've marked the PR as ready for review again.

hugovk
hugovk approved these changes Jul 19, 2026
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, let's go ahead with the Internet Archive then.

@codahale Thanks for confirming, and for writing the article in the first place.

Comment thread Doc/library/secrets.rst Outdated
@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 20, 2026
@hugovk
hugovk merged commit e804232 into python:main Jul 20, 2026
36 checks passed
@miss-islington-app

miss-islington-app Bot commented Jul 20, 2026

Copy link
Copy Markdown

Thanks @pranavchoudhary-tech for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jul 20, 2026
@bedevere-app

bedevere-app Bot commented Jul 20, 2026

Copy link
Copy Markdown

GH-154213 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 20, 2026
@bedevere-app

bedevere-app Bot commented Jul 20, 2026

Copy link
Copy Markdown

GH-154214 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 20, 2026
@bedevere-app

bedevere-app Bot commented Jul 20, 2026

Copy link
Copy Markdown

GH-154215 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 20, 2026
hugovk pushed a commit that referenced this pull request Jul 20, 2026
@miss-islington @pranavchoudhary-tech
[3.13] gh-154046: docs: fix dead link to codahale timing attacks arti…
e23e510 
…cle in secrets.rst (GH-154047) (#154215)

gh-154046: docs: fix dead link to codahale timing attacks article in secrets.rst (GH-154047)
(cherry picked from commit e804232)

Co-authored-by: Pranav Choudhary <pranav.nstblr@gmail.com>
hugovk pushed a commit that referenced this pull request Jul 20, 2026
@miss-islington @pranavchoudhary-tech
[3.15] gh-154046: docs: fix dead link to codahale timing attacks arti…
404a81d 
…cle in secrets.rst (GH-154047) (#154213)

gh-154046: docs: fix dead link to codahale timing attacks article in secrets.rst (GH-154047)
(cherry picked from commit e804232)

Co-authored-by: Pranav Choudhary <pranav.nstblr@gmail.com>
hugovk pushed a commit that referenced this pull request Jul 20, 2026
@miss-islington @pranavchoudhary-tech
[3.14] gh-154046: docs: fix dead link to codahale timing attacks arti…
2a1f381 
…cle in secrets.rst (GH-154047) (#154214)

gh-154046: docs: fix dead link to codahale timing attacks article in secrets.rst (GH-154047)
(cherry picked from commit e804232)

Co-authored-by: Pranav Choudhary <pranav.nstblr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs: Dead link to Coda Hale's timing attacks article in secrets.rst

3 participants

@pranavchoudhary-tech @hugovk @codahale