gh-53907: Reset the digest auth retry count when authentication fails#153646
Open
soreavis wants to merge 3 commits into
Open
gh-53907: Reset the digest auth retry count when authentication fails#153646soreavis wants to merge 3 commits into
soreavis wants to merge 3 commits into
Conversation
… fails HTTPDigestAuthHandler.http_error_401() resets the retry count only when http_error_auth_reqed() returns normally. It doesn't when it raises -- and it raises once the count passes 5. The count stays set, so every later request through the same handler fails straight away with "digest auth failed", even with valid credentials. Reset it in a finally block so it runs on every exit path. ProxyDigestAuthHandler.http_error_407() had the same bug.
|
All commit authors signed the Contributor License Agreement. |
regrtest reports the unclosed response as an env change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTPDigestAuthHandler.http_error_401()resets the retry count only whenhttp_error_auth_reqed()returns normally. It doesn't when it raises — and it raises once the count passes 5. The count stays set, so every later request through the same handler fails straight away withdigest auth failed, even with valid credentials.Reset it in a
finallyblock so it runs on every exit path.ProxyDigestAuthHandler.http_error_407()had the same bug.#53907