Skip to content

[3.14] gh-144023: Prevent follow_symlinks from being allowed with an fd of 0 (GH-144022) #144151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Jan 22, 2026
Merged

[3.14] gh-144023: Prevent follow_symlinks from being allowed with an fd of 0 (GH-144022) #144151

vstinner merged 1 commit into from
Jan 22, 2026
+15 −1

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Jan 22, 2026 •
edited by bedevere-app bot
Loading

The check was (fd > 0), should be (fd >= 0).
(cherry picked from commit fa44efa)

@AZero13 @StanFromIreland
[3.14] pythongh-144023: Prevent follow_symlinks from being allowed wi…
2eb421f 
…th an fd of 0 (pythonGH-144022)

The check was (fd > 0), should be (fd >= 0).
(cherry picked from commit fa44efa)

Co-authored-by: AZero13 <gfunni234@gmail.com>
@bedevere-app bedevere-app bot mentioned this pull request Jan 22, 2026
Closed
@bedevere-app bedevere-app bot mentioned this pull request Jan 22, 2026
Merged
@vstinner
Copy link
Member

vstinner commented Jan 22, 2026

Oh, git on the CI failed (Lint, Check if Autoconf files are up to date, Ubuntu...) with exit code 128.

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Jan 22, 2026

Oh, git on the CI failed (Lint, Check if Autoconf files are up to date, Ubuntu...) with exit code 128.

Hmm, that's a new one.

@hugovk
Copy link
Member

hugovk commented Jan 22, 2026

GitHub problems:

Error: fatal: unable to access 'https://github.com/python/cpython/': The requested URL returned error: 500

->

https://www.githubstatus.com/incidents/cqb5hcy0gx18

@vstinner vstinner enabled auto-merge (squash) January 22, 2026 15:38
@vstinner vstinner merged commit fbc8155 into python:3.14 Jan 22, 2026
85 of 89 checks passed
@StanFromIreland StanFromIreland deleted the backport-fa44efa-3.14 branch January 22, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland @vstinner @hugovk @AZero13