Skip to content

gh-75572: Only require the "cpu" resource for the slowest tests in test_xpickle #143956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serhiy-storchaka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-75572: Only require the "cpu" resource for the slowest tests in test_xpickle #143956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion Lib/test/test_xpickle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ def have_python_version(py_version):
return py_executable_map.get(py_version, None)


@support.requires_resource('cpu')
class AbstractCompatTests(pickletester.AbstractPickleTests):
py_version = None

Expand Down Expand Up @@ -207,6 +206,24 @@ def test_bytes(self):
test_oob_buffers = None
test_oob_buffers_writable_to_readonly = None

slow_tests = [
'test_ints', # 14 sec
'test_int_pickling_efficiency', # 8 sec
'test_builtin_exceptions', # 8 sec
'test_builtin_functions', # 5 sec
'test_long', # 4 sec
'test_builtin_types', # 3 sec
'test_float', # 2.4 sec
'test_framing_many_objects', # 1.7 sec
'test_bytes_memoization', # 1.5 sec
'test_bytearray_memoization', # 1.4 sec
]

for name in slow_tests:
t = getattr(AbstractCompatTests, name)
t = support.requires_resource('cpu')(t)
setattr(AbstractCompatTests, name, t)

class PyPicklePythonCompat(AbstractCompatTests):
pickler = pickle._Pickler
unpickler = pickle._Unpickler
Expand Down
Loading