gh-141431: interpret ZIP timestamps as UTC #143953
Closed
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanshAgarwal24036
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
Member
|
If the tests are failing please do not open a PR or fix them or make it a draft. I will be closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZIP (DOS) timestamps do not include timezone information, but CPython currently
interprets them as local time via time.mktime(). This can cause .pyc files to be
incorrectly marked as stale when a zipapp is created and run in different
timezones.
This change uses calendar.timegm() so ZIP source timestamps are interpreted with
UTC semantics, matching .pyc timestamp handling.
Fixes gh-141431