synchronous fixture setup and teardown #138
Open
agnesnatasya wants to merge 11 commits intopython-trio:masterfrom
Open
synchronous fixture setup and teardown #138agnesnatasya wants to merge 11 commits intopython-trio:masterfrom
agnesnatasya wants to merge 11 commits intopython-trio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly fixes #137, by making fixtures setup and teardown synchronous
Related issues and discussions:
ContextapproachImplementation details
contextvarnot intertwining with each otherConcerns
This is my first PR, want to double check if I've done the complete checklist
asendfromcodespell, so I just disabledcodespelland committed without thecodespellcheckPYTHONPATH="pytest-trio" pytest pytest-trioand I received 2 xfailed, and 1 warning.PYTHONPATHLet me know if I'm missing anything, would appreciate any feedback :D