Preserve used imports during filtered import cleanup - #877
Open
yangfan-yf-yf wants to merge 1 commit into
Open
yangfan-yf-yf wants to merge 1 commit into
yangfan-yf-yf wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #811.
Moving a global from a package module can remove a still-used aliased import when another
fromimport from the same package precedes it. In the reported example, movingmodule1_global_variableleavesproxy_module1_function()referencingutils_moduleafter its import has been deleted, so calling it raisesNameError.I traced this to
AddingVisitor: it reports a successful merge into a read-only import statement even though that statement rejects the update. Duplicate removal then deletes the other import. The visitor now accepts a read-only destination only when its existing names and aliases already cover the incoming import. New names, aliases, and star imports remain in their own statements; genuine duplicates can still be removed.I added a move regression and import-filter tests covering distinct names, aliases, star imports, identical imports, and imports already covered by a superset or star. I also ran the original three-module example in separate Python processes before and after moving the variable: both executions now return
2 1 1.Validation on Windows / Python 3.12.3:
Checklist