fix: create parent dir if not present in the ouput param path#161
Open
Vipulkr1698 wants to merge 2 commits intopython-poetry:mainfrom
Open
fix: create parent dir if not present in the ouput param path#161Vipulkr1698 wants to merge 2 commits intopython-poetry:mainfrom
Vipulkr1698 wants to merge 2 commits intopython-poetry:mainfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
neersighted
requested changes
Nov 14, 2022
Member
neersighted
left a comment
There was a problem hiding this comment.
Pathlib functions should be used instead of os.path; e.g. output.parent. However, that isn't sufficient -- this is too naive. Tests should be written, which should reveal where more thought is needed.
Also, this is very clearly a new feature and not a fix; Poetry has never claimed to create these paths before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








When using the command of the below format
poetry export -o package/lib/requirements.txt
In the above example, if the package/lib directory doesn't exist, the above command would fail. With the fix, the tool would create all the necessary intermediate folders to the file path provided and export the dependencies to the file provided.