Repository navigation
Apply invert, posterize and solarize to the palette of a P image - #10174
Open
RavSinghChandan wants to merge 4 commits into
Open
RavSinghChandan wants to merge 4 commits into
RavSinghChandan wants to merge 4 commits into
Conversation
Member
Lines 495 to 496 in b01a706 |
Contributor
Author
|
You're right, thanks, my description was wrong about equalize(). The guard only matters for autocontrast(), which builds its table from image.histogram(), and for a P image that counts palette indexes. Your version looks good to me. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
ImageOps.invert(),posterize()andsolarize()raisedNotImplementedError: mode P support coming soonfor a P image, from the FIXME in_lut(): "apply to lookup table, not image data".autocontrast()andequalize()build their table from the histogram, which for a P image counts palette indexes rather than colors, so they still raise as before.