Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
precisedelta(timedelta(days=4_000_000))currently raisesOverflowError: date value out of range. The duration itself is valid; the failure comes from constructing a calendar date that this formatter never uses. The same limit affects numeric seconds andtimedelta.min/timedelta.max.Operate directly on absolute timedeltas for duration inputs, retaining the existing relative-date path for datetime inputs. Annotate the unit accumulators as float because unit suppression and minimum-unit rounding can produce fractional counts.
Six regressions cover signed4-million-day timedeltas, the corresponding numeric seconds, and the timedelta bounds. All six fail before the fix. Afterward,735 behavior/doctest cases pass with112 translation-related skips, strict
mypy .passes, all repository prek hooks pass, andgit diff --checkpasses. Performance benchmarks were excluded from this behavior run.Prepared with AI assistance.