Add Windows ARM64 build - #314
Conversation
|
Also I'm not sure if this change is significant enough for inclusion in AUTHORS, I added that because the PR template said so, but can remove it no problem. |
Merging this PR will improve performance by 11.91%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | test_get_import_details |
161.3 µs | 144.2 µs | +11.91% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ndabas:main (66a5eb6) with main (f4d9ecf)
Footnotes
-
23 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
seddonym
left a comment
There was a problem hiding this comment.
Thanks for your contribution! (You should definitely be listed in the contributors 😄 .)
I'm all for building the Windows ARM64 wheels, but if we're doing that, shouldn't we also be running tests under that architecture in the same way?
|
Thank you! I can add Windows ARM64 to the test job too -- the reason I didn't already is that currently, that job only runs for Ubuntu (x64), macOS (arm64), and Windows (x64) -- but we already build for a whole lot of other architectures (e.g. armv7, arm64, etc. on Linux) and those aren't tested either. So the simplistic approach might just be to add Windows ARM64 to the test matrix, which will look quite odd IMHO because all of the other architectures will be missing. The other, better way I think would be to add testing to the end of the wheel build process, so that we can test every wheel that we build. I'd be happy to do it either way -- what do you think? |
That's a good point. I think aligning all these would be scope creep for this PR, so I've merged it as-is. From what I understand, given we're using pyo3, cross-architecture issues are less likely, and it could really slow down CI to run under every architecture because some of them may require emulation which is a lot slower. Perhaps it would be worth running tests for each architecture during the release process, but I'll leave that for another day. Thanks for your contribution! |
|
I'm now going to test the release workflow manually to check everything builds ok. |
|
Thank you very much, that workflow worked fine in my fork so hopefully all should be good. |
|
Yep, looks good. Thanks again! |
latestsection at the top ofCHANGELOG.rst. (If it's not there, add it.)AUTHORS.rst.just full-check.As the title says.
The changes look slightly crazy because:
aarch64as the architecture while setup-python wants to seearm64.