Skip to content

Fix Locale subclass __str__ issue #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chiifouu wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

Fix Locale subclass __str__ issue #1271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion babel/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,9 @@ def __init__(
self.modifier = modifier
self.__data: localedata.LocaleDataDict | None = None

identifier = str(self)
identifier = get_locale_identifier(
(self.language, self.territory, self.script, self.variant, self.modifier),
)
identifier_without_modifier = identifier.partition('@')[0]
if localedata.exists(identifier):
self.__data_identifier = identifier
Expand Down
8 changes: 8 additions & 0 deletions tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,14 @@ def test_attributes(self):
locale = Locale('en', 'US')
assert locale.language == 'en'
assert locale.territory == 'US'

def test_locale_subclass_custom_str(self):
class MyLocale(Locale):
def __str__(self):
return f"[{self.language}]"
locale = MyLocale("en")
assert locale.language == "en"
assert str(locale) == "[en]"

def test_default(self, monkeypatch):
for name in ['LANGUAGE', 'LC_ALL', 'LC_CTYPE', 'LC_MESSAGES']:
Expand Down