Repository navigation
faulthandler: register faulthandler_timeout as type=float - #15152
Closed
artem-sitd wants to merge 1 commit into
Closed
artem-sitd wants to merge 1 commit into
artem-sitd wants to merge 1 commit into
Conversation
Member
|
Duplicate of #15133 (and also unnecessarily beckwards incompatible for toml) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #15132.
Problem
faulthandler_timeoutwas registered without atype, so it defaulted tostring. In TOML configuration (pytest.toml/pyproject.toml) a native number — the documented and example form — was rejected:Change
Register
faulthandler_timeoutwithtype="float"(src/_pytest/faulthandler.py), matching its documented:type:and the float coercion already done in the faulthandler plugin. This is consistent with the other typed options (bool,int,float), all of which reject strings in TOML mode.INI string values keep working (coerced
str -> floatin_getini_ini), sofaulthandler_timeout = 5in an.inifile is unchanged behaviour.Tests
Added
test_timeout_accepts_native_toml_numbersintesting/test_faulthandler.py; fulltest_faulthandler.pyandTestConfigAPIpass.Changelog fragment added as
changelog/15132.bugfix.rst.