Introduce ExitCode.COLLECTION_ERROR for collection errors - #15012
Open
SemTiOne wants to merge 5 commits into
Open
Introduce ExitCode.COLLECTION_ERROR for collection errors#15012SemTiOne wants to merge 5 commits into
ExitCode.COLLECTION_ERROR for collection errors#15012SemTiOne wants to merge 5 commits into
Conversation
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
RonnyPfannschmidt
approved these changes
Sep 13, 2026
RonnyPfannschmidt
left a comment
Member
There was a problem hiding this comment.
I like it
We may need to assess if this is breaking for some people
Member
|
ci fixed needed |
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
ExitCode.COLLECTION_ERROR for collection errorsExitCode.COLLECTION_ERROR for collection errors
SemTiOne
marked this pull request as ready for review
September 13, 2026 13:17
Pierre-Sassoulas
approved these changes
Sep 13, 2026
Pierre-Sassoulas
left a comment
Member
There was a problem hiding this comment.
LGTM. More tests changed than code is a good sign.
Member
|
please investigate what triggered the rtd failure |
Contributor
Author
|
GTG. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4603
Previously collection errors exited 2, they now exit 7 (
ExitCode.COLLECTION_ERROR).closes #XYZWto the PR description and/or commits (whereXYZWis the issue number). See the github docs for more information.Co-authored-bycommit trailers.changelogdirectory, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.AUTHORSin alphabetical order.