Conversation
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
| self, | ||
| lines2: Sequence[str], | ||
| *, | ||
| consecutive: bool = False, |
There was a problem hiding this comment.
the original issue noted that this maybe better served as option
as part of the matchers experiments i have been considering that rather than adding bools to this method
we should have a matcher to specify the behaviour
this should be shelved for a design decission
There was a problem hiding this comment.
Thanks, that makes sense. Is there a sketch of the matcher API I could target? Since this is default-off, a later matcher API could subsume it without breaking existing callers. Acceptable as an interim step, or shelve until the design decision lands?
There was a problem hiding this comment.
for now shelfe - i may need a bit longer to get back to making a POC of matchers - currently its a internal design document only
Closes #6820
Adds a
completeoption toLineMatcher.fnmatch_linesandLineMatcher.re_match_lines. The assertion fails on unasserted output lines.Prior art: blueyed#257 explored this first. This converges on the per-call flag while reporting all unasserted lines at the end instead of failing at the first gap, so trailing leftovers are caught too.
closes #XYZWto the PR description and/or commits (whereXYZWis the issue number). See the github docs for more information.Co-authored-bycommit trailers.changelogdirectory, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.AUTHORSin alphabetical order.