[ruff] Adopt the new default rule from 0.16 that are already green - #14895
Merged
Pierre-Sassoulas merged 2 commits intoAug 17, 2026
Merged
Conversation
``lint.select`` replaces ruff's default selection rather than adding to it, so the 413 rules ruff 0.16 enables by default never applied here: 142 of them were outside our selection. Switching to ``lint.extend-select`` makes them apply again. To keep this commit behaviour-neutral, every rule that was not already running is added to ``lint.ignore``. The following commits remove those entries one by one, fixing the code or documenting why the rule stays off. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Eighty-six of the rules ruff 0.16 enables by default are already satisfied by the code base, so switching them on touches nothing but 'lint.ignore': flake8-2020, flake8-async, flake8-comprehensions, flake8-datetimez, flake8-executable, flake8-gettext, flake8-logging, flake8-logging-format, flake8-pytest-style, flake8-simplify, flake8-type-checking, perflint, refurb and tryceratops. The rules from those same families that do need a code change get one commit each, further along the branch. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Pierre-Sassoulas
added
the
skip news
nicoddemus
approved these changes
Aug 17, 2026
RonnyPfannschmidt
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lint.select was replacing the default values from ruff (maybe a good thing seeing the churn), but it means we missed the new default from ruff 0.16. I have a draft of everything that need fixing in my fork but let's go slow.