Extend instance method fixture deprecation to all higher scopes#14774
Open
The-Compiler wants to merge 1 commit into
Open
Extend instance method fixture deprecation to all higher scopes#14774The-Compiler wants to merge 1 commit into
The-Compiler wants to merge 1 commit into
Conversation
The-Compiler
force-pushed
the
deprecate-class-fixt-higher-scope
branch
2 times, most recently
from
July 24, 2026 09:12
fe8223a to
7416018
Compare
The-Compiler
force-pushed
the
main
branch
2 times, most recently
from
July 24, 2026 09:22
cb2ee5b to
ced9022
Compare
The original deprecation in pytest-dev#14071 only targetted class-scoped fixtures, but the same issue exists if someone implements a module/package/session-scoped fixture as an instance method. Closes pytest-dev#14765
The-Compiler
force-pushed
the
deprecate-class-fixt-higher-scope
branch
from
July 24, 2026 09:25
7416018 to
78a1938
Compare
psf-chronographer
Bot
added
the
bot:chronographer:provided
bluetech
approved these changes
Jul 24, 2026
bluetech
left a comment
bluetech
left a comment
Member
There was a problem hiding this comment.
Good catch, thanks. These are less common which is why we didn't think about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original deprecation in #14071 only targetted class-scoped fixtures, but the same issue exists if someone implements a module/package/session-scoped fixture as an instance method.