Reject implicit option destination conflicts#14661
Open
w-Jessamine wants to merge 3 commits into
Open
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
| for group in self.parser._groups: | ||
| for option in group.options: | ||
| if option.dest == dest: | ||
| raise ValueError( |
Contributor
There was a problem hiding this comment.
Nit pick but I am thinking if we make the error message a bit more clear?
Maybe something like:
"option dest keyword already used by ['-k'] (this is the option that maps to dest keyword); pass dest='keyword' explicitly to share the destination"
Author
There was a problem hiding this comment.
Thanks, updated the error message to include the existing option and explicit dest guidance.
Aditya-Tripuraneni
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12824.
Custom options added with
parser.addoption()can currently derive an implicitdestthat collides with an existing pytest option. For example,--keywordderivesdest="keyword", which silently overwrites the built-in-koption destination and causes the value to be interpreted as a keyword selection expression.This change rejects implicit destination conflicts with a clear error, while still allowing intentional shared destinations when
dest=...is passed explicitly. That preserves existing pytest patterns such as--capture/-sand--maxfail/-x.Testing
python -m pytest testing/test_parseopt.py testing/test_config.py -qpython -m ruff check src/_pytest/config/argparsing.py testing/test_parseopt.pypython -m ruff format --check src/_pytest/config/argparsing.py testing/test_parseopt.py